From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Date: Tue, 03 Jul 2018 07:34:52 +0000 Subject: Re: [PATCH] video/console/vgacon: Print big fat warning with nomodeset Message-Id: <20180703073452.GD7880@phenom.ffwll.local> List-Id: References: <20180702210442.18648-1-lyude@redhat.com> In-Reply-To: <20180702210442.18648-1-lyude@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Lyude Paul Cc: linux-fbdev@vger.kernel.org, Kees Cook , Bartlomiej Zolnierkiewicz , Jan =?iso-8859-1?Q?H=2E_Sch=F6nherr?= , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Bjorn Helgaas On Mon, Jul 02, 2018 at 05:04:40PM -0400, Lyude Paul wrote: > It's been a pretty good while since kernel modesetting was introduced. > It has almost entirely replaced previous solutions which required > userspace modesetting, and I can't even recall any drivers off the top > of my head for modern day hardware that don't only support one or the > other. Even nvidia's ugly blob does not require the use of nomodeset, > and only requires that nouveau be blacklisted. > > Effectively, the only thing nomodeset does in the year 2018 is disable > your graphics drivers. Since VESA is a thing, this will give many users > the false impression that they've actually fixed an issue they were > having with their machine simply because the laptop will boot up to a > degraded GUI. This of course, is never actually the case. > > Things get even worse when you consider that there's still an enormous > amount of tutorials users find on the internet that still suggest adding > nomodeset, along with various users who have been around long enough to > still suggest it. > > There really isn't any legitimate reason I can see for this to be an > option that's used by anyone else other then developers, or properly > informed users. So, let's end the confusion and start printing warnings > whenever it's enabled. > > Signed-off-by: Lyude Paul Yeah makes tons of sense. I think we should also perhaps mark the option as a tainting one, but I think that's only wired up for module option. Reviewed-by: Daniel Vetter > --- > drivers/video/console/vgacon.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/video/console/vgacon.c b/drivers/video/console/vgacon.c > index f09e17b60e45..09731b2f6815 100644 > --- a/drivers/video/console/vgacon.c > +++ b/drivers/video/console/vgacon.c > @@ -112,6 +112,11 @@ EXPORT_SYMBOL(vgacon_text_force); > static int __init text_mode(char *str) > { > vgacon_text_mode_force = true; > + > + pr_warning("You have booted with nomodeset. This means your GPU drivers are DISABLED\n"); > + pr_warning("Any video related functionality will be severely degraded, and you may not even be able to suspend the system properly\n"); > + pr_warning("Unless you actually understand what nomodeset does, you should reboot without enabling it\n"); > + > return 1; > } > > -- > 2.17.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] video/console/vgacon: Print big fat warning with nomodeset Date: Tue, 3 Jul 2018 09:34:52 +0200 Message-ID: <20180703073452.GD7880@phenom.ffwll.local> References: <20180702210442.18648-1-lyude@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-ed1-x542.google.com (mail-ed1-x542.google.com [IPv6:2a00:1450:4864:20::542]) by gabe.freedesktop.org (Postfix) with ESMTPS id A1DD46E57E for ; Tue, 3 Jul 2018 07:34:56 +0000 (UTC) Received: by mail-ed1-x542.google.com with SMTP id u11-v6so870337eds.10 for ; Tue, 03 Jul 2018 00:34:56 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20180702210442.18648-1-lyude@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Lyude Paul Cc: linux-fbdev@vger.kernel.org, Kees Cook , Bartlomiej Zolnierkiewicz , Jan =?iso-8859-1?Q?H=2E_Sch=F6nherr?= , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Bjorn Helgaas List-Id: dri-devel@lists.freedesktop.org T24gTW9uLCBKdWwgMDIsIDIwMTggYXQgMDU6MDQ6NDBQTSAtMDQwMCwgTHl1ZGUgUGF1bCB3cm90 ZToKPiBJdCdzIGJlZW4gYSBwcmV0dHkgZ29vZCB3aGlsZSBzaW5jZSBrZXJuZWwgbW9kZXNldHRp bmcgd2FzIGludHJvZHVjZWQuCj4gSXQgaGFzIGFsbW9zdCBlbnRpcmVseSByZXBsYWNlZCBwcmV2 aW91cyBzb2x1dGlvbnMgd2hpY2ggcmVxdWlyZWQKPiB1c2Vyc3BhY2UgbW9kZXNldHRpbmcsIGFu ZCBJIGNhbid0IGV2ZW4gcmVjYWxsIGFueSBkcml2ZXJzIG9mZiB0aGUgdG9wCj4gb2YgbXkgaGVh ZCBmb3IgbW9kZXJuIGRheSBoYXJkd2FyZSB0aGF0IGRvbid0IG9ubHkgc3VwcG9ydCBvbmUgb3Ig dGhlCj4gb3RoZXIuIEV2ZW4gbnZpZGlhJ3MgdWdseSBibG9iIGRvZXMgbm90IHJlcXVpcmUgdGhl IHVzZSBvZiBub21vZGVzZXQsCj4gYW5kIG9ubHkgcmVxdWlyZXMgdGhhdCBub3V2ZWF1IGJlIGJs YWNrbGlzdGVkLgo+IAo+IEVmZmVjdGl2ZWx5LCB0aGUgb25seSB0aGluZyBub21vZGVzZXQgZG9l cyBpbiB0aGUgeWVhciAyMDE4IGlzIGRpc2FibGUKPiB5b3VyIGdyYXBoaWNzIGRyaXZlcnMuIFNp bmNlIFZFU0EgaXMgYSB0aGluZywgdGhpcyB3aWxsIGdpdmUgbWFueSB1c2Vycwo+IHRoZSBmYWxz ZSBpbXByZXNzaW9uIHRoYXQgdGhleSd2ZSBhY3R1YWxseSBmaXhlZCBhbiBpc3N1ZSB0aGV5IHdl cmUKPiBoYXZpbmcgd2l0aCB0aGVpciBtYWNoaW5lIHNpbXBseSBiZWNhdXNlIHRoZSBsYXB0b3Ag d2lsbCBib290IHVwIHRvIGEKPiBkZWdyYWRlZCBHVUkuIFRoaXMgb2YgY291cnNlLCBpcyBuZXZl ciBhY3R1YWxseSB0aGUgY2FzZS4KPiAKPiBUaGluZ3MgZ2V0IGV2ZW4gd29yc2Ugd2hlbiB5b3Ug Y29uc2lkZXIgdGhhdCB0aGVyZSdzIHN0aWxsIGFuIGVub3Jtb3VzCj4gYW1vdW50IG9mIHR1dG9y aWFscyB1c2VycyBmaW5kIG9uIHRoZSBpbnRlcm5ldCB0aGF0IHN0aWxsIHN1Z2dlc3QgYWRkaW5n Cj4gbm9tb2Rlc2V0LCBhbG9uZyB3aXRoIHZhcmlvdXMgdXNlcnMgd2hvIGhhdmUgYmVlbiBhcm91 bmQgbG9uZyBlbm91Z2ggdG8KPiBzdGlsbCBzdWdnZXN0IGl0Lgo+IAo+IFRoZXJlIHJlYWxseSBp c24ndCBhbnkgbGVnaXRpbWF0ZSByZWFzb24gSSBjYW4gc2VlIGZvciB0aGlzIHRvIGJlIGFuCj4g b3B0aW9uIHRoYXQncyB1c2VkIGJ5IGFueW9uZSBlbHNlIG90aGVyIHRoZW4gZGV2ZWxvcGVycywg b3IgcHJvcGVybHkKPiBpbmZvcm1lZCB1c2Vycy4gU28sIGxldCdzIGVuZCB0aGUgY29uZnVzaW9u IGFuZCBzdGFydCBwcmludGluZyB3YXJuaW5ncwo+IHdoZW5ldmVyIGl0J3MgZW5hYmxlZC4KPiAK PiBTaWduZWQtb2ZmLWJ5OiBMeXVkZSBQYXVsIDxseXVkZUByZWRoYXQuY29tPgoKWWVhaCBtYWtl cyB0b25zIG9mIHNlbnNlLiBJIHRoaW5rIHdlIHNob3VsZCBhbHNvIHBlcmhhcHMgbWFyayB0aGUg b3B0aW9uCmFzIGEgdGFpbnRpbmcgb25lLCBidXQgSSB0aGluayB0aGF0J3Mgb25seSB3aXJlZCB1 cCBmb3IgbW9kdWxlIG9wdGlvbi4KClJldmlld2VkLWJ5OiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwu dmV0dGVyQGZmd2xsLmNoPgoKPiAtLS0KPiAgZHJpdmVycy92aWRlby9jb25zb2xlL3ZnYWNvbi5j IHwgNSArKysrKwo+ICAxIGZpbGUgY2hhbmdlZCwgNSBpbnNlcnRpb25zKCspCj4gCj4gZGlmZiAt LWdpdCBhL2RyaXZlcnMvdmlkZW8vY29uc29sZS92Z2Fjb24uYyBiL2RyaXZlcnMvdmlkZW8vY29u c29sZS92Z2Fjb24uYwo+IGluZGV4IGYwOWUxN2I2MGU0NS4uMDk3MzFiMmY2ODE1IDEwMDY0NAo+ IC0tLSBhL2RyaXZlcnMvdmlkZW8vY29uc29sZS92Z2Fjb24uYwo+ICsrKyBiL2RyaXZlcnMvdmlk ZW8vY29uc29sZS92Z2Fjb24uYwo+IEBAIC0xMTIsNiArMTEyLDExIEBAIEVYUE9SVF9TWU1CT0wo dmdhY29uX3RleHRfZm9yY2UpOwo+ICBzdGF0aWMgaW50IF9faW5pdCB0ZXh0X21vZGUoY2hhciAq c3RyKQo+ICB7Cj4gIAl2Z2Fjb25fdGV4dF9tb2RlX2ZvcmNlID0gdHJ1ZTsKPiArCj4gKwlwcl93 YXJuaW5nKCJZb3UgaGF2ZSBib290ZWQgd2l0aCBub21vZGVzZXQuIFRoaXMgbWVhbnMgeW91ciBH UFUgZHJpdmVycyBhcmUgRElTQUJMRURcbiIpOwo+ICsJcHJfd2FybmluZygiQW55IHZpZGVvIHJl bGF0ZWQgZnVuY3Rpb25hbGl0eSB3aWxsIGJlIHNldmVyZWx5IGRlZ3JhZGVkLCBhbmQgeW91IG1h eSBub3QgZXZlbiBiZSBhYmxlIHRvIHN1c3BlbmQgdGhlIHN5c3RlbSBwcm9wZXJseVxuIik7Cj4g Kwlwcl93YXJuaW5nKCJVbmxlc3MgeW91IGFjdHVhbGx5IHVuZGVyc3RhbmQgd2hhdCBub21vZGVz ZXQgZG9lcywgeW91IHNob3VsZCByZWJvb3Qgd2l0aG91dCBlbmFibGluZyBpdFxuIik7Cj4gKwo+ ICAJcmV0dXJuIDE7Cj4gIH0KPiAgCj4gLS0gCj4gMi4xNy4xCj4gCj4gX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBkcmktZGV2ZWwgbWFpbGluZyBsaXN0 Cj4gZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJlZWRl c2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCgotLSAKRGFuaWVsIFZldHRlcgpT b2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwuY2gK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,T_DKIM_INVALID, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29DC7C6778A for ; Tue, 3 Jul 2018 07:35:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C8E0024D34 for ; Tue, 3 Jul 2018 07:35:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="VFi4dcSD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C8E0024D34 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933290AbeGCHe7 (ORCPT ); Tue, 3 Jul 2018 03:34:59 -0400 Received: from mail-ed1-f68.google.com ([209.85.208.68]:39240 "EHLO mail-ed1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932688AbeGCHe4 (ORCPT ); Tue, 3 Jul 2018 03:34:56 -0400 Received: by mail-ed1-f68.google.com with SMTP id w14-v6so882611eds.6 for ; Tue, 03 Jul 2018 00:34:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=sender:date:from:to:cc:subject:message-id:mail-followup-to :references:mime-version:content-disposition:in-reply-to:user-agent; bh=mB53gJ91j8FOITUcvkI07qBBdMqsZk+hAzRvB/uDde4=; b=VFi4dcSDoqTmWFrTuyDjn4mHGQN+1QYHR4sdRKDk1rS2BVM3NlGQvmOZrdWhUTVhYY xCp7siLc35XQT9Mt8qyoJGHf6/rgZLwFOztqek8qIUhE2uxAiS7zOpkhTfW1wOKErbYW PJiMAB9E5PLQWoHu8yrUBJ9Rqupdo1vpOE37Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to:user-agent; bh=mB53gJ91j8FOITUcvkI07qBBdMqsZk+hAzRvB/uDde4=; b=D6aWwvfP6u2NGuDdshK0byiaKRIntz/V+ncAe0hEzdc4zkmMqWugAUN+wsGB+qWDtG p8qdz0LGCprpnFQ/OU85iEeM6Uu4GFMJzx8Lt/OqALJQr2lo3Ar4cE97PNrZg0pogwM7 JXNyfspTnnECw0pGO0NTVjQM4WF+09//xKqZjCA3trtKtlVqhMPpqDFvtyVcbsiK5iPo y7aVtIDCYfLJNIZBLmp0tAyFWod5h4lF5Ky/4sJbf/zK6u8AApKyWRK8LTkgQ45ZSXVT 5nDz/6VxYk6ZwvMK8gJ6bzuX4Mm6K0Gl3cLQYJvhMmqIlUkjgrs5xzRhd27n/xayrSlu tYLg== X-Gm-Message-State: APt69E1RwafARLt32fih1GL+Jmtnsuo/O1P9QB7pwFxCc5tq1auUz7ul Ai77Iugb56ryQmt6arJLhWW2SA== X-Google-Smtp-Source: AAOMgpdy4BioJyvM6uWk498F+eIER2DbvjR9vSIgjo1Z153L+K5VcWocRsyiPIAILQ8F04/+8UQgLQ== X-Received: by 2002:aa7:c396:: with SMTP id k22-v6mr27573108edq.149.1530603295331; Tue, 03 Jul 2018 00:34:55 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:5628:0:496f:7dc5:66d7:a057]) by smtp.gmail.com with ESMTPSA id j7-v6sm395007edh.76.2018.07.03.00.34.54 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 03 Jul 2018 00:34:54 -0700 (PDT) Date: Tue, 3 Jul 2018 09:34:52 +0200 From: Daniel Vetter To: Lyude Paul Cc: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, Kees Cook , Bartlomiej Zolnierkiewicz , Jan =?iso-8859-1?Q?H=2E_Sch=F6nherr?= , linux-kernel@vger.kernel.org, Bjorn Helgaas Subject: Re: [PATCH] video/console/vgacon: Print big fat warning with nomodeset Message-ID: <20180703073452.GD7880@phenom.ffwll.local> Mail-Followup-To: Lyude Paul , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, Kees Cook , Bartlomiej Zolnierkiewicz , Jan =?iso-8859-1?Q?H=2E_Sch=F6nherr?= , linux-kernel@vger.kernel.org, Bjorn Helgaas References: <20180702210442.18648-1-lyude@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180702210442.18648-1-lyude@redhat.com> X-Operating-System: Linux phenom 4.16.0-2-amd64 User-Agent: Mutt/1.10.0 (2018-05-17) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 02, 2018 at 05:04:40PM -0400, Lyude Paul wrote: > It's been a pretty good while since kernel modesetting was introduced. > It has almost entirely replaced previous solutions which required > userspace modesetting, and I can't even recall any drivers off the top > of my head for modern day hardware that don't only support one or the > other. Even nvidia's ugly blob does not require the use of nomodeset, > and only requires that nouveau be blacklisted. > > Effectively, the only thing nomodeset does in the year 2018 is disable > your graphics drivers. Since VESA is a thing, this will give many users > the false impression that they've actually fixed an issue they were > having with their machine simply because the laptop will boot up to a > degraded GUI. This of course, is never actually the case. > > Things get even worse when you consider that there's still an enormous > amount of tutorials users find on the internet that still suggest adding > nomodeset, along with various users who have been around long enough to > still suggest it. > > There really isn't any legitimate reason I can see for this to be an > option that's used by anyone else other then developers, or properly > informed users. So, let's end the confusion and start printing warnings > whenever it's enabled. > > Signed-off-by: Lyude Paul Yeah makes tons of sense. I think we should also perhaps mark the option as a tainting one, but I think that's only wired up for module option. Reviewed-by: Daniel Vetter > --- > drivers/video/console/vgacon.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/video/console/vgacon.c b/drivers/video/console/vgacon.c > index f09e17b60e45..09731b2f6815 100644 > --- a/drivers/video/console/vgacon.c > +++ b/drivers/video/console/vgacon.c > @@ -112,6 +112,11 @@ EXPORT_SYMBOL(vgacon_text_force); > static int __init text_mode(char *str) > { > vgacon_text_mode_force = true; > + > + pr_warning("You have booted with nomodeset. This means your GPU drivers are DISABLED\n"); > + pr_warning("Any video related functionality will be severely degraded, and you may not even be able to suspend the system properly\n"); > + pr_warning("Unless you actually understand what nomodeset does, you should reboot without enabling it\n"); > + > return 1; > } > > -- > 2.17.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch