From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH v7 3/6] mfd: cros-ec: Increase maximum mkbp event size Date: Tue, 3 Jul 2018 10:43:44 +0100 Message-ID: <20180703094344.GR20176@dell> References: <1527841154-24832-1-git-send-email-narmstrong@baylibre.com> <1527841154-24832-4-git-send-email-narmstrong@baylibre.com> <20180618074443.GK31141@dell> <017e4688-4036-e606-7220-2e472afa0aac@baylibre.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x243.google.com (mail-wm0-x243.google.com [IPv6:2a00:1450:400c:c09::243]) by gabe.freedesktop.org (Postfix) with ESMTPS id EF1306E5DF for ; Tue, 3 Jul 2018 09:43:47 +0000 (UTC) Received: by mail-wm0-x243.google.com with SMTP id n17-v6so1550478wmh.2 for ; Tue, 03 Jul 2018 02:43:47 -0700 (PDT) Content-Disposition: inline In-Reply-To: <017e4688-4036-e606-7220-2e472afa0aac@baylibre.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Neil Armstrong Cc: seanpaul@google.com, fparent@baylibre.com, airlied@linux.ie, sadolfsson@google.com, intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Stefan Adolfsson , felixe@google.com, hans.verkuil@cisco.com, marcheu@chromium.org, bleung@google.com, darekm@google.com, linux-media@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org T24gTW9uLCAxOCBKdW4gMjAxOCwgTmVpbCBBcm1zdHJvbmcgd3JvdGU6Cgo+IEhpIExlZSwKPiAK PiBPbiAxOC8wNi8yMDE4IDA5OjQ0LCBMZWUgSm9uZXMgd3JvdGU6Cj4gPiBPbiBGcmksIDAxIEp1 biAyMDE4LCBOZWlsIEFybXN0cm9uZyB3cm90ZToKPiA+IAo+ID4+IEhhdmluZyBhIDE2IGJ5dGUg bWticCBldmVudCBzaXplIG1ha2VzIGl0IHBvc3NpYmxlIHRvIHNlbmQgQ0VDCj4gPj4gbWVzc2Fn ZXMgZnJvbSB0aGUgRUMgdG8gdGhlIEFQIGRpcmVjdGx5IGluc2lkZSB0aGUgbWticCBldmVudAo+ ID4+IGluc3RlYWQgb2YgZmlyc3QgZG9pbmcgYSBub3RpZmljYXRpb24gYW5kIHRoZW4gYSByZWFk Lgo+ID4+Cj4gPj4gU2lnbmVkLW9mZi1ieTogU3RlZmFuIEFkb2xmc3NvbiA8c2Fkb2xmc3NvbkBj aHJvbWl1bS5vcmc+Cj4gPj4gU2lnbmVkLW9mZi1ieTogTmVpbCBBcm1zdHJvbmcgPG5hcm1zdHJv bmdAYmF5bGlicmUuY29tPgo+ID4+IFRlc3RlZC1ieTogRW5yaWMgQmFsbGV0Ym8gaSBTZXJyYSA8 ZW5yaWMuYmFsbGV0Ym9AY29sbGFib3JhLmNvbT4KPiA+PiAtLS0KPiA+PiAgZHJpdmVycy9wbGF0 Zm9ybS9jaHJvbWUvY3Jvc19lY19wcm90by5jIHwgNDAgKysrKysrKysrKysrKysrKysrKysrKysr Ky0tLS0tLS0tCj4gPj4gIGluY2x1ZGUvbGludXgvbWZkL2Nyb3NfZWMuaCAgICAgICAgICAgICB8 ICAyICstCj4gPj4gIGluY2x1ZGUvbGludXgvbWZkL2Nyb3NfZWNfY29tbWFuZHMuaCAgICB8IDE5 ICsrKysrKysrKysrKysrKysKPiA+PiAgMyBmaWxlcyBjaGFuZ2VkLCA1MSBpbnNlcnRpb25zKCsp LCAxMCBkZWxldGlvbnMoLSkKPiA+Pgo+ID4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3BsYXRmb3Jt L2Nocm9tZS9jcm9zX2VjX3Byb3RvLmMgYi9kcml2ZXJzL3BsYXRmb3JtL2Nocm9tZS9jcm9zX2Vj X3Byb3RvLmMKPiA+PiBpbmRleCBlN2JiZGY5Li5jNGY2YzQ0IDEwMDY0NAo+ID4+IC0tLSBhL2Ry aXZlcnMvcGxhdGZvcm0vY2hyb21lL2Nyb3NfZWNfcHJvdG8uYwo+ID4+ICsrKyBiL2RyaXZlcnMv cGxhdGZvcm0vY2hyb21lL2Nyb3NfZWNfcHJvdG8uYwo+ID4+IEBAIC01MDQsMTAgKzUwNCwzMSBA QCBpbnQgY3Jvc19lY19jbWRfeGZlcl9zdGF0dXMoc3RydWN0IGNyb3NfZWNfZGV2aWNlICplY19k ZXYsCj4gPj4gIH0KPiA+PiAgRVhQT1JUX1NZTUJPTChjcm9zX2VjX2NtZF94ZmVyX3N0YXR1cyk7 Cj4gPj4gIAo+ID4+ICtzdGF0aWMgaW50IGdldF9uZXh0X2V2ZW50X3hmZXIoc3RydWN0IGNyb3Nf ZWNfZGV2aWNlICplY19kZXYsCj4gPj4gKwkJCSAgICAgICBzdHJ1Y3QgY3Jvc19lY19jb21tYW5k ICptc2csCj4gPj4gKwkJCSAgICAgICBpbnQgdmVyc2lvbiwgdWludDMyX3Qgc2l6ZSkKPiA+PiAr ewo+ID4+ICsJaW50IHJldDsKPiA+PiArCj4gPj4gKwltc2ctPnZlcnNpb24gPSB2ZXJzaW9uOwo+ ID4+ICsJbXNnLT5jb21tYW5kID0gRUNfQ01EX0dFVF9ORVhUX0VWRU5UOwo+ID4+ICsJbXNnLT5p bnNpemUgPSBzaXplOwo+ID4+ICsJbXNnLT5vdXRzaXplID0gMDsKPiA+PiArCj4gPj4gKwlyZXQg PSBjcm9zX2VjX2NtZF94ZmVyKGVjX2RldiwgbXNnKTsKPiA+PiArCWlmIChyZXQgPiAwKSB7Cj4g Pj4gKwkJZWNfZGV2LT5ldmVudF9zaXplID0gcmV0IC0gMTsKPiA+PiArCQltZW1jcHkoJmVjX2Rl di0+ZXZlbnRfZGF0YSwgbXNnLT5kYXRhLCBlY19kZXYtPmV2ZW50X3NpemUpOwo+ID4+ICsJfQo+ ID4+ICsKPiA+PiArCXJldHVybiByZXQ7Cj4gPj4gK30KPiA+PiArCj4gPj4gIHN0YXRpYyBpbnQg Z2V0X25leHRfZXZlbnQoc3RydWN0IGNyb3NfZWNfZGV2aWNlICplY19kZXYpCj4gPj4gIHsKPiA+ PiAgCXU4IGJ1ZmZlcltzaXplb2Yoc3RydWN0IGNyb3NfZWNfY29tbWFuZCkgKyBzaXplb2YoZWNf ZGV2LT5ldmVudF9kYXRhKV07Cj4gPj4gIAlzdHJ1Y3QgY3Jvc19lY19jb21tYW5kICptc2cgPSAo c3RydWN0IGNyb3NfZWNfY29tbWFuZCAqKSZidWZmZXI7Cj4gPj4gKwlzdGF0aWMgaW50IGNtZF92 ZXJzaW9uID0gMTsKPiA+PiAgCWludCByZXQ7Cj4gPj4gIAo+ID4+ICAJaWYgKGVjX2Rldi0+c3Vz cGVuZGVkKSB7Cj4gPj4gQEAgLTUxNSwxOCArNTM2LDE5IEBAIHN0YXRpYyBpbnQgZ2V0X25leHRf ZXZlbnQoc3RydWN0IGNyb3NfZWNfZGV2aWNlICplY19kZXYpCj4gPj4gIAkJcmV0dXJuIC1FSE9T VERPV047Cj4gPj4gIAl9Cj4gPj4gIAo+ID4+IC0JbXNnLT52ZXJzaW9uID0gMDsKPiA+PiAtCW1z Zy0+Y29tbWFuZCA9IEVDX0NNRF9HRVRfTkVYVF9FVkVOVDsKPiA+PiAtCW1zZy0+aW5zaXplID0g c2l6ZW9mKGVjX2Rldi0+ZXZlbnRfZGF0YSk7Cj4gPj4gLQltc2ctPm91dHNpemUgPSAwOwo+ID4+ ICsJaWYgKGNtZF92ZXJzaW9uID09IDEpIHsKPiA+PiArCQlyZXQgPSBnZXRfbmV4dF9ldmVudF94 ZmVyKGVjX2RldiwgbXNnLCBjbWRfdmVyc2lvbiwKPiA+PiArCQkJCXNpemVvZihzdHJ1Y3QgZWNf cmVzcG9uc2VfZ2V0X25leHRfZXZlbnRfdjEpKTsKPiA+PiArCQlpZiAocmV0IDwgMCB8fCBtc2ct PnJlc3VsdCAhPSBFQ19SRVNfSU5WQUxJRF9WRVJTSU9OKQo+ID4+ICsJCQlyZXR1cm4gcmV0Owo+ ID4+ICAKPiA+PiAtCXJldCA9IGNyb3NfZWNfY21kX3hmZXIoZWNfZGV2LCBtc2cpOwo+ID4+IC0J aWYgKHJldCA+IDApIHsKPiA+PiAtCQllY19kZXYtPmV2ZW50X3NpemUgPSByZXQgLSAxOwo+ID4+ IC0JCW1lbWNweSgmZWNfZGV2LT5ldmVudF9kYXRhLCBtc2ctPmRhdGEsCj4gPj4gLQkJICAgICAg IHNpemVvZihlY19kZXYtPmV2ZW50X2RhdGEpKTsKPiA+PiArCQkvKiBGYWxsYmFjayB0byB2ZXJz aW9uIDAgZm9yIGZ1dHVyZSBzZW5kIGF0dGVtcHRzICovCj4gPj4gKwkJY21kX3ZlcnNpb24gPSAw Owo+ID4+ICAJfQo+ID4+ICAKPiA+PiArCXJldCA9IGdldF9uZXh0X2V2ZW50X3hmZXIoZWNfZGV2 LCBtc2csIGNtZF92ZXJzaW9uLAo+ID4+ICsJCQkJICBzaXplb2Yoc3RydWN0IGVjX3Jlc3BvbnNl X2dldF9uZXh0X2V2ZW50KSk7Cj4gPj4gKwo+ID4+ICAJcmV0dXJuIHJldDsKPiA+PiAgfQo+ID4+ ICAKPiA+PiBkaWZmIC0tZ2l0IGEvaW5jbHVkZS9saW51eC9tZmQvY3Jvc19lYy5oIGIvaW5jbHVk ZS9saW51eC9tZmQvY3Jvc19lYy5oCj4gPj4gaW5kZXggZjM2MTI1ZS4uMzJjYWVmMyAxMDA2NDQK PiA+PiAtLS0gYS9pbmNsdWRlL2xpbnV4L21mZC9jcm9zX2VjLmgKPiA+PiArKysgYi9pbmNsdWRl L2xpbnV4L21mZC9jcm9zX2VjLmgKPiA+PiBAQCAtMTQ3LDcgKzE0Nyw3IEBAIHN0cnVjdCBjcm9z X2VjX2RldmljZSB7Cj4gPj4gIAlib29sIG1rYnBfZXZlbnRfc3VwcG9ydGVkOwo+ID4+ICAJc3Ry dWN0IGJsb2NraW5nX25vdGlmaWVyX2hlYWQgZXZlbnRfbm90aWZpZXI7Cj4gPj4gIAo+ID4+IC0J c3RydWN0IGVjX3Jlc3BvbnNlX2dldF9uZXh0X2V2ZW50IGV2ZW50X2RhdGE7Cj4gPj4gKwlzdHJ1 Y3QgZWNfcmVzcG9uc2VfZ2V0X25leHRfZXZlbnRfdjEgZXZlbnRfZGF0YTsKPiA+PiAgCWludCBl dmVudF9zaXplOwo+ID4+ICAJdTMyIGhvc3RfZXZlbnRfd2FrZV9tYXNrOwo+ID4+ICB9Owo+ID4+ IGRpZmYgLS1naXQgYS9pbmNsdWRlL2xpbnV4L21mZC9jcm9zX2VjX2NvbW1hbmRzLmggYi9pbmNs dWRlL2xpbnV4L21mZC9jcm9zX2VjX2NvbW1hbmRzLmgKPiA+PiBpbmRleCBmMmVkZDk5Li5jYzA3 NjhlIDEwMDY0NAo+ID4+IC0tLSBhL2luY2x1ZGUvbGludXgvbWZkL2Nyb3NfZWNfY29tbWFuZHMu aAo+ID4+ICsrKyBiL2luY2x1ZGUvbGludXgvbWZkL2Nyb3NfZWNfY29tbWFuZHMuaAo+ID4+IEBA IC0yMDkzLDEyICsyMDkzLDMxIEBAIHVuaW9uIGVjX3Jlc3BvbnNlX2dldF9uZXh0X2RhdGEgewo+ ID4+ICAJdWludDMyX3QgICBzeXNycTsKPiA+PiAgfSBfX3BhY2tlZDsKPiA+PiAgCj4gPj4gK3Vu aW9uIGVjX3Jlc3BvbnNlX2dldF9uZXh0X2RhdGFfdjEgewo+ID4+ICsJdWludDhfdCAgIGtleV9t YXRyaXhbMTZdOwo+ID4+ICsKPiA+PiArCS8qIFVuYWxpZ25lZCAqLwo+ID4gCj4gPiBUaGF0J3Mg ZnVubnkhCj4gPiAKPiA+PiArCXVpbnQzMl90ICBob3N0X2V2ZW50Owo+ID4+ICsKPiA+PiArCXVp bnQzMl90ICAgYnV0dG9uczsKPiA+PiArCXVpbnQzMl90ICAgc3dpdGNoZXM7Cj4gPj4gKwl1aW50 MzJfdCAgIHN5c3JxOwo+ID4+ICsJdWludDMyX3QgICBjZWNfZXZlbnRzOwo+ID4+ICsJdWludDhf dCAgICBjZWNfbWVzc2FnZVsxNl07Cj4gPiAKPiA+IFNpbmNlIHRoZXJlIGFyZSBzb21lIHdoaXRl c3BhY2UgYWxpZ25tZW50IGlzc3VlcyBpbiBoZXJlLgoKRml4IHRoZSB3aGl0ZSBzcGFjZSBpc3N1 ZXMuCgo+ID4+ICt9IF9fcGFja2VkOwo+ID4gCj4gPiBIb3cgY29tZSB0aGVzZSBndXlzIGhhdmUg a2VybmVsZG9jIGhlYWRlcnM/CgpDb25zaWRlciB1c2luZyBrZXJuZWxkb2MgaGVhZGVycyAobm90 IHJlcXVpcmVkIGZvciB0aGlzIHBhdGNoKS4KCj4gQ2FuIHlvdSBleHBsaWNpdCB3aGF0IHNob3Vs ZCBiZSBjaGFuZ2VkIGhlcmUgPwoKLV4KCj4gPj4gIHN0cnVjdCBlY19yZXNwb25zZV9nZXRfbmV4 dF9ldmVudCB7Cj4gPj4gIAl1aW50OF90IGV2ZW50X3R5cGU7Cj4gPj4gIAkvKiBGb2xsb3dlZCBi eSBldmVudCBkYXRhIGlmIGFueSAqLwo+ID4+ICAJdW5pb24gZWNfcmVzcG9uc2VfZ2V0X25leHRf ZGF0YSBkYXRhOwo+ID4+ICB9IF9fcGFja2VkOwo+ID4+ICAKPiA+PiArc3RydWN0IGVjX3Jlc3Bv bnNlX2dldF9uZXh0X2V2ZW50X3YxIHsKPiA+PiArCXVpbnQ4X3QgZXZlbnRfdHlwZTsKPiA+PiAr CS8qIEZvbGxvd2VkIGJ5IGV2ZW50IGRhdGEgaWYgYW55ICovCj4gPj4gKwl1bmlvbiBlY19yZXNw b25zZV9nZXRfbmV4dF9kYXRhX3YxIGRhdGE7Cj4gPj4gK30gX19wYWNrZWQ7Cj4gPj4gKwo+ID4+ ICAvKiBCaXQgaW5kaWNlcyBmb3IgYnV0dG9ucyBhbmQgc3dpdGNoZXMuKi8KPiA+PiAgLyogQnV0 dG9ucyAqLwo+ID4+ICAjZGVmaW5lIEVDX01LQlBfUE9XRVJfQlVUVE9OCTAKPiA+IAo+IAoKLS0g CkxlZSBKb25lcyBb5p2O55C85pavXQpMaW5hcm8gU2VydmljZXMgVGVjaG5pY2FsIExlYWQKTGlu YXJvLm9yZyDilIIgT3BlbiBzb3VyY2Ugc29mdHdhcmUgZm9yIEFSTSBTb0NzCkZvbGxvdyBMaW5h cm86IEZhY2Vib29rIHwgVHdpdHRlciB8IEJsb2cKX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlz dHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4v bGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-wm0-f65.google.com ([74.125.82.65]:52164 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754500AbeGCJnr (ORCPT ); Tue, 3 Jul 2018 05:43:47 -0400 Received: by mail-wm0-f65.google.com with SMTP id s12-v6so1602380wmc.1 for ; Tue, 03 Jul 2018 02:43:47 -0700 (PDT) Date: Tue, 3 Jul 2018 10:43:44 +0100 From: Lee Jones To: Neil Armstrong Cc: airlied@linux.ie, hans.verkuil@cisco.com, olof@lixom.net, seanpaul@google.com, sadolfsson@google.com, felixe@google.com, bleung@google.com, darekm@google.com, marcheu@chromium.org, fparent@baylibre.com, dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, eballetbo@gmail.com, Stefan Adolfsson Subject: Re: [PATCH v7 3/6] mfd: cros-ec: Increase maximum mkbp event size Message-ID: <20180703094344.GR20176@dell> References: <1527841154-24832-1-git-send-email-narmstrong@baylibre.com> <1527841154-24832-4-git-send-email-narmstrong@baylibre.com> <20180618074443.GK31141@dell> <017e4688-4036-e606-7220-2e472afa0aac@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <017e4688-4036-e606-7220-2e472afa0aac@baylibre.com> Sender: linux-media-owner@vger.kernel.org List-ID: On Mon, 18 Jun 2018, Neil Armstrong wrote: > Hi Lee, > > On 18/06/2018 09:44, Lee Jones wrote: > > On Fri, 01 Jun 2018, Neil Armstrong wrote: > > > >> Having a 16 byte mkbp event size makes it possible to send CEC > >> messages from the EC to the AP directly inside the mkbp event > >> instead of first doing a notification and then a read. > >> > >> Signed-off-by: Stefan Adolfsson > >> Signed-off-by: Neil Armstrong > >> Tested-by: Enric Balletbo i Serra > >> --- > >> drivers/platform/chrome/cros_ec_proto.c | 40 +++++++++++++++++++++++++-------- > >> include/linux/mfd/cros_ec.h | 2 +- > >> include/linux/mfd/cros_ec_commands.h | 19 ++++++++++++++++ > >> 3 files changed, 51 insertions(+), 10 deletions(-) > >> > >> diff --git a/drivers/platform/chrome/cros_ec_proto.c b/drivers/platform/chrome/cros_ec_proto.c > >> index e7bbdf9..c4f6c44 100644 > >> --- a/drivers/platform/chrome/cros_ec_proto.c > >> +++ b/drivers/platform/chrome/cros_ec_proto.c > >> @@ -504,10 +504,31 @@ int cros_ec_cmd_xfer_status(struct cros_ec_device *ec_dev, > >> } > >> EXPORT_SYMBOL(cros_ec_cmd_xfer_status); > >> > >> +static int get_next_event_xfer(struct cros_ec_device *ec_dev, > >> + struct cros_ec_command *msg, > >> + int version, uint32_t size) > >> +{ > >> + int ret; > >> + > >> + msg->version = version; > >> + msg->command = EC_CMD_GET_NEXT_EVENT; > >> + msg->insize = size; > >> + msg->outsize = 0; > >> + > >> + ret = cros_ec_cmd_xfer(ec_dev, msg); > >> + if (ret > 0) { > >> + ec_dev->event_size = ret - 1; > >> + memcpy(&ec_dev->event_data, msg->data, ec_dev->event_size); > >> + } > >> + > >> + return ret; > >> +} > >> + > >> static int get_next_event(struct cros_ec_device *ec_dev) > >> { > >> u8 buffer[sizeof(struct cros_ec_command) + sizeof(ec_dev->event_data)]; > >> struct cros_ec_command *msg = (struct cros_ec_command *)&buffer; > >> + static int cmd_version = 1; > >> int ret; > >> > >> if (ec_dev->suspended) { > >> @@ -515,18 +536,19 @@ static int get_next_event(struct cros_ec_device *ec_dev) > >> return -EHOSTDOWN; > >> } > >> > >> - msg->version = 0; > >> - msg->command = EC_CMD_GET_NEXT_EVENT; > >> - msg->insize = sizeof(ec_dev->event_data); > >> - msg->outsize = 0; > >> + if (cmd_version == 1) { > >> + ret = get_next_event_xfer(ec_dev, msg, cmd_version, > >> + sizeof(struct ec_response_get_next_event_v1)); > >> + if (ret < 0 || msg->result != EC_RES_INVALID_VERSION) > >> + return ret; > >> > >> - ret = cros_ec_cmd_xfer(ec_dev, msg); > >> - if (ret > 0) { > >> - ec_dev->event_size = ret - 1; > >> - memcpy(&ec_dev->event_data, msg->data, > >> - sizeof(ec_dev->event_data)); > >> + /* Fallback to version 0 for future send attempts */ > >> + cmd_version = 0; > >> } > >> > >> + ret = get_next_event_xfer(ec_dev, msg, cmd_version, > >> + sizeof(struct ec_response_get_next_event)); > >> + > >> return ret; > >> } > >> > >> diff --git a/include/linux/mfd/cros_ec.h b/include/linux/mfd/cros_ec.h > >> index f36125e..32caef3 100644 > >> --- a/include/linux/mfd/cros_ec.h > >> +++ b/include/linux/mfd/cros_ec.h > >> @@ -147,7 +147,7 @@ struct cros_ec_device { > >> bool mkbp_event_supported; > >> struct blocking_notifier_head event_notifier; > >> > >> - struct ec_response_get_next_event event_data; > >> + struct ec_response_get_next_event_v1 event_data; > >> int event_size; > >> u32 host_event_wake_mask; > >> }; > >> diff --git a/include/linux/mfd/cros_ec_commands.h b/include/linux/mfd/cros_ec_commands.h > >> index f2edd99..cc0768e 100644 > >> --- a/include/linux/mfd/cros_ec_commands.h > >> +++ b/include/linux/mfd/cros_ec_commands.h > >> @@ -2093,12 +2093,31 @@ union ec_response_get_next_data { > >> uint32_t sysrq; > >> } __packed; > >> > >> +union ec_response_get_next_data_v1 { > >> + uint8_t key_matrix[16]; > >> + > >> + /* Unaligned */ > > > > That's funny! > > > >> + uint32_t host_event; > >> + > >> + uint32_t buttons; > >> + uint32_t switches; > >> + uint32_t sysrq; > >> + uint32_t cec_events; > >> + uint8_t cec_message[16]; > > > > Since there are some whitespace alignment issues in here. Fix the white space issues. > >> +} __packed; > > > > How come these guys have kerneldoc headers? Consider using kerneldoc headers (not required for this patch). > Can you explicit what should be changed here ? -^ > >> struct ec_response_get_next_event { > >> uint8_t event_type; > >> /* Followed by event data if any */ > >> union ec_response_get_next_data data; > >> } __packed; > >> > >> +struct ec_response_get_next_event_v1 { > >> + uint8_t event_type; > >> + /* Followed by event data if any */ > >> + union ec_response_get_next_data_v1 data; > >> +} __packed; > >> + > >> /* Bit indices for buttons and switches.*/ > >> /* Buttons */ > >> #define EC_MKBP_POWER_BUTTON 0 > > > -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog