From: Kevin Wolf <kwolf@redhat.com>
To: qemu-block@nongnu.org
Cc: kwolf@redhat.com, peter.maydell@linaro.org, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PULL 1/5] qemu-img: allow compressed not-in-order writes
Date: Tue, 3 Jul 2018 16:59:11 +0200 [thread overview]
Message-ID: <20180703145915.32607-2-kwolf@redhat.com> (raw)
In-Reply-To: <20180703145915.32607-1-kwolf@redhat.com>
From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
No reason to forbid them, and they are needed to improve performance
with compress-threads in further patches.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
qemu-img.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/qemu-img.c b/qemu-img.c
index e1a506f7f6..7651d8172c 100644
--- a/qemu-img.c
+++ b/qemu-img.c
@@ -2141,11 +2141,6 @@ static int img_convert(int argc, char **argv)
goto fail_getopt;
}
- if (!s.wr_in_order && s.compressed) {
- error_report("Out of order write and compress are mutually exclusive");
- goto fail_getopt;
- }
-
if (tgt_image_opts && !skip_create) {
error_report("--target-image-opts requires use of -n flag");
goto fail_getopt;
--
2.13.6
next prev parent reply other threads:[~2018-07-03 14:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-03 14:59 [Qemu-devel] [PULL 0/5] Block layer patches Kevin Wolf
2018-07-03 14:59 ` Kevin Wolf [this message]
2018-07-03 14:59 ` [Qemu-devel] [PULL 2/5] qcow2: refactor data compression Kevin Wolf
2018-07-03 14:59 ` [Qemu-devel] [PULL 3/5] qcow2: add compress threads Kevin Wolf
2018-07-03 14:59 ` [Qemu-devel] [PULL 4/5] block: Move two block permission constants to the relevant enum Kevin Wolf
2018-07-03 14:59 ` [Qemu-devel] [PULL 5/5] block: Add blklogwrites Kevin Wolf
2018-07-03 15:07 ` Kevin Wolf
2018-07-04 18:30 ` [Qemu-devel] [PULL 0/5] Block layer patches Peter Maydell
2018-07-05 8:28 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180703145915.32607-2-kwolf@redhat.com \
--to=kwolf@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.