From: Igor Mammedov <imammedo@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
Babu Moger <babu.moger@amd.com>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] pc: Fix typo on PC_COMPAT_2_12
Date: Tue, 3 Jul 2018 17:07:20 +0200 [thread overview]
Message-ID: <20180703170720.72a210b2@redhat.com> (raw)
In-Reply-To: <20180703011026.18650-1-ehabkost@redhat.com>
On Mon, 2 Jul 2018 22:10:26 -0300
Eduardo Habkost <ehabkost@redhat.com> wrote:
> I forgot a hyphen when amending the compat code on commit
> e0051647 ("i386: Enable TOPOEXT feature on AMD EPYC CPU").
>
> Fixes: e00516475c270dcb6705753da96063f95699abf2
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
> Bug detected by compat_checker:
> https://github.com/ehabkost/gdb-qemu
> ---
> include/hw/i386/pc.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h
> index 4d99d69681..654003f44c 100644
> --- a/include/hw/i386/pc.h
> +++ b/include/hw/i386/pc.h
> @@ -309,7 +309,7 @@ bool e820_get_entry(int, uint32_t, uint64_t *, uint64_t *);
> .property = "xlevel",\
> .value = stringify(0x8000000a),\
> },{\
> - .driver = "EPYC-IBPB" TYPE_X86_CPU,\
> + .driver = "EPYC-IBPB-" TYPE_X86_CPU,\
> .property = "xlevel",\
> .value = stringify(0x8000000a),\
> },
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
next prev parent reply other threads:[~2018-07-03 15:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-03 1:10 [Qemu-devel] [PATCH] pc: Fix typo on PC_COMPAT_2_12 Eduardo Habkost
2018-07-03 15:07 ` Igor Mammedov [this message]
2018-07-09 15:48 ` Moger, Babu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180703170720.72a210b2@redhat.com \
--to=imammedo@redhat.com \
--cc=babu.moger@amd.com \
--cc=ehabkost@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.