From: Alexandru Moise <00moses.alexander00@gmail.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: stable@vger.kernel.org, gregkh@linuxfoundation.org
Subject: Re: [PATCH] block: don't use blocking queue entered for recursive bio submits
Date: Tue, 3 Jul 2018 23:39:32 +0200 [thread overview]
Message-ID: <20180703213932.GA10884@gmail.com> (raw)
In-Reply-To: <8e959bb2-5cd8-9a1d-bc48-1e32f2681ef4@kernel.dk>
On Tue, Jul 03, 2018 at 03:20:31PM -0600, Jens Axboe wrote:
> On 7/3/18 3:15 PM, Jens Axboe wrote:
> > commit cd4a4ae4683dc2e09380118e205e057896dcda2b upstream.
> >
> > If we end up splitting a bio and the queue goes away between
> > the initial submission and the later split submission, then we
> > can block forever in blk_queue_enter() waiting for the reference
> > to drop to zero. This will never happen, since we already hold
> > a reference.
> >
> > Mark a split bio as already having entered the queue, so we can
> > just use the live non-blocking queue enter variant.
> >
> > Thanks to Tetsuo Handa for the analysis.
> >
> > We're running fio tests and the tasks get stuck in a D state forever
> > when systemd-udevd tries to read the partition table. This patch solves
> > it. Please apply to 4.17 stable.
> >
> > Reported-by: syzbot+c4f9cebf9d651f6e54de@syzkaller.appspotmail.com
> > Signed-off-by: Jens Axboe <axboe@kernel.dk>
> > Signed-off-by: Alexandru Moise <00moses.alexander00@gmail.com>
>
> WTF? Please don't send out emails with my name. Ever.
>
Crap, that's the last thing I intended. I need to set fire to my scripts now, along with my lazy eye.
Please accept my most sincere apologies for this stupid mistake.
../Alex
> --
> Jens Axboe
>
prev parent reply other threads:[~2018-07-03 21:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-03 21:15 [PATCH] block: don't use blocking queue entered for recursive bio submits Jens Axboe
2018-07-03 21:20 ` Jens Axboe
2018-07-03 21:39 ` Alexandru Moise [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180703213932.GA10884@gmail.com \
--to=00moses.alexander00@gmail.com \
--cc=axboe@kernel.dk \
--cc=gregkh@linuxfoundation.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.