From: Rob Herring <robh@kernel.org>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Andreas Klinger <ak@it-klinger.de>,
knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net,
mark.rutland@arm.com, mchehab@kernel.org, davem@davemloft.net,
gregkh@linuxfoundation.org, akpm@linux-foundation.org,
linus.walleij@linaro.org, rdunlap@infradead.org,
devicetree@vger.kernel.org, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/4] iio: hx711: add data-ready-delay-ns property in DT
Date: Tue, 3 Jul 2018 15:48:43 -0600 [thread overview]
Message-ID: <20180703214843.GA484@rob-hp-laptop> (raw)
In-Reply-To: <20180630183232.540ce031@archlinux>
On Sat, Jun 30, 2018 at 06:32:32PM +0100, Jonathan Cameron wrote:
> On Mon, 25 Jun 2018 17:18:02 +0200
> Andreas Klinger <ak@it-klinger.de> wrote:
>
> > add data-ready-delay-ns property for hx711 ADC
> > this is the delay after rising PD_SCK until DOUT is read and assumed to be
> > ready
> >
> > Signed-off-by: Andreas Klinger <ak@it-klinger.de>
>
> Hmm. It's not particularly generic... I think this should have
> have vendor prefix until we have some visibility of whether it
> is a common thing we want to standardise around or not.
Agreed. Doesn't look like any interface I've seen before.
Since it's bit-banging, seems to me it would be better to specify the
frequency for PD_SCK and sample DOUT just before or after setting PD_SCK
low.
Rob
> I'll also be waiting for a devicetree ack on this one as it's a
> tiny bit unusual.
>
> Thanks,
>
> Jonathan
prev parent reply other threads:[~2018-07-03 21:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-25 15:18 [PATCH v2 1/4] iio: hx711: add data-ready-delay-ns property in DT Andreas Klinger
2018-06-30 17:32 ` Jonathan Cameron
2018-07-03 21:48 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180703214843.GA484@rob-hp-laptop \
--to=robh@kernel.org \
--cc=ak@it-klinger.de \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linus.walleij@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mchehab@kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.