From: Lukas Wunner <lukas@wunner.de>
To: Lyude Paul <lyude@redhat.com>
Cc: nouveau@lists.freedesktop.org, David Airlie <airlied@linux.ie>,
dri-devel@lists.freedesktop.org, Ben Skeggs <bskeggs@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] drm/nouveau: Fix runtime PM leak in drm_open()
Date: Wed, 4 Jul 2018 04:41:03 +0200 [thread overview]
Message-ID: <20180704024103.GA23762@wunner.de> (raw)
In-Reply-To: <20180703220602.16664-2-lyude@redhat.com>
[cc -= stable]
On Tue, Jul 03, 2018 at 06:05:59PM -0400, Lyude Paul wrote:
> Noticed this as I was skimming through, if we fail to allocate memory
> for cli we'll end up returning without dropping the runtime PM ref we
> got. Additionally, we'll even return the wrong return code! (ret most
> likely will == 0 here, we want -ENOMEM).
>
> Signed-off-by: Lyude Paul <lyude@redhat.com>
Reviewed-by: Lukas Wunner <lukas@wunner.de>
next prev parent reply other threads:[~2018-07-04 2:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-03 22:05 [PATCH 0/2] drm/nouveau: Fix runtime PM leaks Lyude Paul
2018-07-03 22:05 ` Lyude Paul
[not found] ` <20180703220602.16664-1-lyude-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2018-07-03 22:05 ` [PATCH 1/2] drm/nouveau: Fix runtime PM leak in drm_open() Lyude Paul
2018-07-03 22:05 ` Lyude Paul
2018-07-04 2:41 ` Lukas Wunner [this message]
2018-07-03 22:06 ` [PATCH 2/2] drm/nouveau: Fix runtime PM leak in nv50_disp_atomic_commit() Lyude Paul
2018-07-03 22:06 ` Lyude Paul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180704024103.GA23762@wunner.de \
--to=lukas@wunner.de \
--cc=airlied@linux.ie \
--cc=bskeggs@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lyude@redhat.com \
--cc=nouveau@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.