From: Tiwei Bie <tiwei.bie@intel.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>
Cc: zhihong.wang@intel.com, jfreimann@redhat.com, dev@dpdk.org,
mst@redhat.com, jasowang@redhat.com, wexu@redhat.com
Subject: Re: [PATCH v6 01/15] vhost: add virtio packed virtqueue defines
Date: Wed, 4 Jul 2018 13:37:33 +0800 [thread overview]
Message-ID: <20180704053733.GA28826@debian> (raw)
In-Reply-To: <20180702081629.29258-2-maxime.coquelin@redhat.com>
On Mon, Jul 02, 2018 at 10:16:15AM +0200, Maxime Coquelin wrote:
> From: Jens Freimann <jfreimann@redhat.com>
>
> Signed-off-by: Jens Freimann <jfreimann@redhat.com>
> ---
> lib/librte_vhost/vhost.h | 3 +++
> lib/librte_vhost/virtio-packed.h | 22 ++++++++++++++++++++++
> 2 files changed, 25 insertions(+)
> create mode 100644 lib/librte_vhost/virtio-packed.h
>
> diff --git a/lib/librte_vhost/vhost.h b/lib/librte_vhost/vhost.h
> index 3f8fa3a78..cecd5c1ee 100644
> --- a/lib/librte_vhost/vhost.h
> +++ b/lib/librte_vhost/vhost.h
> @@ -191,6 +191,9 @@ struct vhost_msg {
> #ifndef VIRTIO_F_VERSION_1
> #define VIRTIO_F_VERSION_1 32
> #endif
> +#ifndef VIRTIO_F_RING_PACKED
> + #define VIRTIO_F_RING_PACKED 34
> +#endif
>
> /* Features supported by this builtin vhost-user net driver. */
> #define VIRTIO_NET_SUPPORTED_FEATURES ((1ULL << VIRTIO_NET_F_MRG_RXBUF) | \
> diff --git a/lib/librte_vhost/virtio-packed.h b/lib/librte_vhost/virtio-packed.h
> new file mode 100644
> index 000000000..744b3991b
> --- /dev/null
> +++ b/lib/librte_vhost/virtio-packed.h
> @@ -0,0 +1,22 @@
> +/* SPDX-License-Identifier: BSD-3-Clause
> + * Copyright(c) Red Hat Inc.
> + */
> +
> +#ifndef __VIRTIO_PACKED_H
> +#define __VIRTIO_PACKED_H
> +
> +#define VRING_DESC_F_NEXT 1
> +#define VRING_DESC_F_WRITE 2
> +#define VRING_DESC_F_INDIRECT 4
> +
> +#define VRING_DESC_F_AVAIL (1ULL << 7)
> +#define VRING_DESC_F_USED (1ULL << 15)
Please use space or tab consistently.
> +
> +struct vring_desc_packed {
> + uint64_t addr;
> + uint32_t len;
> + uint16_t index;
> + uint16_t flags;
> +};
> +
> +#endif /* __VIRTIO_PACKED_H */
> --
> 2.14.4
>
next prev parent reply other threads:[~2018-07-04 5:37 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-02 8:16 [PATCH v6 00/15] Vhost: add support to packed ring layout Maxime Coquelin
2018-07-02 8:16 ` [PATCH v6 01/15] vhost: add virtio packed virtqueue defines Maxime Coquelin
2018-07-04 5:37 ` Tiwei Bie [this message]
2018-07-04 16:03 ` Maxime Coquelin
2018-07-02 8:16 ` [PATCH v6 02/15] vhost: add helpers for packed virtqueues Maxime Coquelin
2018-07-04 5:39 ` Tiwei Bie
2018-07-04 16:03 ` Maxime Coquelin
2018-07-02 8:16 ` [PATCH v6 03/15] vhost: vring address setup for packed queues Maxime Coquelin
2018-07-02 8:16 ` [PATCH v6 04/15] vhost: clear shadow used table index at flush time Maxime Coquelin
2018-07-02 8:16 ` [PATCH v6 05/15] vhost: make indirect desc table copy desc type agnostic Maxime Coquelin
2018-07-02 8:16 ` [PATCH v6 06/15] vhost: clear batch copy index at copy time Maxime Coquelin
2018-07-02 8:16 ` [PATCH v6 07/15] vhost: extract split ring handling from Rx and Tx functions Maxime Coquelin
2018-07-04 6:51 ` Tiwei Bie
2018-07-04 21:04 ` Maxime Coquelin
2018-07-02 8:16 ` [PATCH v6 08/15] vhost: append shadow used ring function names with split Maxime Coquelin
2018-07-02 8:16 ` [PATCH v6 09/15] vhost: add shadow used ring support for packed rings Maxime Coquelin
2018-07-02 8:16 ` [PATCH v6 10/15] vhost: create descriptor mapping function Maxime Coquelin
2018-07-04 5:56 ` Tiwei Bie
2018-07-04 16:18 ` Maxime Coquelin
2018-07-02 8:16 ` [PATCH v6 11/15] vhost: add vector filling support for packed ring Maxime Coquelin
2018-07-04 5:53 ` Tiwei Bie
2018-07-04 16:18 ` Maxime Coquelin
2018-07-02 8:16 ` [PATCH v6 12/15] vhost: add Rx " Maxime Coquelin
2018-07-02 8:16 ` [PATCH v6 13/15] vhost: add Tx " Maxime Coquelin
2018-07-04 5:45 ` Tiwei Bie
2018-07-04 16:09 ` Maxime Coquelin
2018-07-02 8:16 ` [PATCH v6 14/15] vhost: add notification " Maxime Coquelin
2018-07-03 5:57 ` Jason Wang
2018-07-03 6:43 ` Maxime Coquelin
2018-07-03 6:06 ` Jason Wang
2018-07-04 16:02 ` Maxime Coquelin
2018-07-04 6:25 ` Tiwei Bie
2018-07-04 20:20 ` Maxime Coquelin
2018-07-02 8:16 ` [PATCH v6 15/15] vhost: advertize packed ring layout support Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180704053733.GA28826@debian \
--to=tiwei.bie@intel.com \
--cc=dev@dpdk.org \
--cc=jasowang@redhat.com \
--cc=jfreimann@redhat.com \
--cc=maxime.coquelin@redhat.com \
--cc=mst@redhat.com \
--cc=wexu@redhat.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.