From mboxrd@z Thu Jan 1 00:00:00 1970 From: lee.jones@linaro.org (Lee Jones) Date: Wed, 4 Jul 2018 08:33:11 +0100 Subject: [PATCH 2/5] mfd: axp20x: Add self-working mode support for AXP806 In-Reply-To: <20180620051540.25617-3-wens@csie.org> References: <20180620051540.25617-1-wens@csie.org> <20180620051540.25617-3-wens@csie.org> Message-ID: <20180704073311.GH20176@dell> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, 20 Jun 2018, Chen-Yu Tsai wrote: > The AXP806 can operate in a standalone "self-working" mode, in which it > is also responsible for power control of the overall system. This mode > is similar to the master mode, but the EN/PWRON pin functions as a power > button, instead of a level-triggered enable switch. > > This patch adds code checking for the new "x-powers,self-working-mode" > property, and a separate mfd_cell list that includes the power button > (PEK) sub-device. > > Signed-off-by: Chen-Yu Tsai > --- > drivers/mfd/axp20x.c | 30 +++++++++++++++++++++++++++--- > 1 file changed, 27 insertions(+), 3 deletions(-) > > diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c > index 9a2ef3d9b8f8..1988881529a9 100644 > --- a/drivers/mfd/axp20x.c > +++ b/drivers/mfd/axp20x.c > @@ -221,6 +221,11 @@ static const struct resource axp803_pek_resources[] = { > DEFINE_RES_IRQ_NAMED(AXP803_IRQ_PEK_FAL_EDGE, "PEK_DBF"), > }; > > +static const struct resource axp806_pek_resources[] = { > + DEFINE_RES_IRQ_NAMED(AXP806_IRQ_POK_RISE, "PEK_DBR"), > + DEFINE_RES_IRQ_NAMED(AXP806_IRQ_POK_FALL, "PEK_DBF"), > +}; > + > static const struct resource axp809_pek_resources[] = { > DEFINE_RES_IRQ_NAMED(AXP809_IRQ_PEK_RIS_EDGE, "PEK_DBR"), > DEFINE_RES_IRQ_NAMED(AXP809_IRQ_PEK_FAL_EDGE, "PEK_DBF"), > @@ -730,6 +735,17 @@ static const struct mfd_cell axp803_cells[] = { > { .name = "axp20x-regulator" }, > }; > > +static const struct mfd_cell axp806_self_working_cells[] = { > + { > + .name = "axp221-pek", > + .num_resources = ARRAY_SIZE(axp806_pek_resources), > + .resources = axp806_pek_resources, > + }, > + { > + .name = "axp20x-regulator", > + }, > +}; Nit: Please place single line entries on a single line. Like this: { .name = "axp20x-regulator", }, After you have made that change, please add my: For my own reference: Acked-for-MFD-by: Lee Jones -- Lee Jones [???] Linaro Services Technical Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH 2/5] mfd: axp20x: Add self-working mode support for AXP806 Date: Wed, 4 Jul 2018 08:33:11 +0100 Message-ID: <20180704073311.GH20176@dell> References: <20180620051540.25617-1-wens@csie.org> <20180620051540.25617-3-wens@csie.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20180620051540.25617-3-wens@csie.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Chen-Yu Tsai Cc: Mark Rutland , devicetree@vger.kernel.org, Maxime Ripard , Andre Przywara , Rob Herring , linux-arm-kernel@lists.infradead.org, Icenowy Zheng List-Id: devicetree@vger.kernel.org T24gV2VkLCAyMCBKdW4gMjAxOCwgQ2hlbi1ZdSBUc2FpIHdyb3RlOgoKPiBUaGUgQVhQODA2IGNh biBvcGVyYXRlIGluIGEgc3RhbmRhbG9uZSAic2VsZi13b3JraW5nIiBtb2RlLCBpbiB3aGljaCBp dAo+IGlzIGFsc28gcmVzcG9uc2libGUgZm9yIHBvd2VyIGNvbnRyb2wgb2YgdGhlIG92ZXJhbGwg c3lzdGVtLiBUaGlzIG1vZGUKPiBpcyBzaW1pbGFyIHRvIHRoZSBtYXN0ZXIgbW9kZSwgYnV0IHRo ZSBFTi9QV1JPTiBwaW4gZnVuY3Rpb25zIGFzIGEgcG93ZXIKPiBidXR0b24sIGluc3RlYWQgb2Yg YSBsZXZlbC10cmlnZ2VyZWQgZW5hYmxlIHN3aXRjaC4KPiAKPiBUaGlzIHBhdGNoIGFkZHMgY29k ZSBjaGVja2luZyBmb3IgdGhlIG5ldyAieC1wb3dlcnMsc2VsZi13b3JraW5nLW1vZGUiCj4gcHJv cGVydHksIGFuZCBhIHNlcGFyYXRlIG1mZF9jZWxsIGxpc3QgdGhhdCBpbmNsdWRlcyB0aGUgcG93 ZXIgYnV0dG9uCj4gKFBFSykgc3ViLWRldmljZS4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBDaGVuLVl1 IFRzYWkgPHdlbnNAY3NpZS5vcmc+Cj4gLS0tCj4gIGRyaXZlcnMvbWZkL2F4cDIweC5jIHwgMzAg KysrKysrKysrKysrKysrKysrKysrKysrKysrLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAyNyBpbnNl cnRpb25zKCspLCAzIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL21mZC9h eHAyMHguYyBiL2RyaXZlcnMvbWZkL2F4cDIweC5jCj4gaW5kZXggOWEyZWYzZDliOGY4Li4xOTg4 ODgxNTI5YTkgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9tZmQvYXhwMjB4LmMKPiArKysgYi9kcml2 ZXJzL21mZC9heHAyMHguYwo+IEBAIC0yMjEsNiArMjIxLDExIEBAIHN0YXRpYyBjb25zdCBzdHJ1 Y3QgcmVzb3VyY2UgYXhwODAzX3Bla19yZXNvdXJjZXNbXSA9IHsKPiAgCURFRklORV9SRVNfSVJR X05BTUVEKEFYUDgwM19JUlFfUEVLX0ZBTF9FREdFLCAiUEVLX0RCRiIpLAo+ICB9Owo+ICAKPiAr c3RhdGljIGNvbnN0IHN0cnVjdCByZXNvdXJjZSBheHA4MDZfcGVrX3Jlc291cmNlc1tdID0gewo+ ICsJREVGSU5FX1JFU19JUlFfTkFNRUQoQVhQODA2X0lSUV9QT0tfUklTRSwgIlBFS19EQlIiKSwK PiArCURFRklORV9SRVNfSVJRX05BTUVEKEFYUDgwNl9JUlFfUE9LX0ZBTEwsICJQRUtfREJGIiks Cj4gK307Cj4gKwo+ICBzdGF0aWMgY29uc3Qgc3RydWN0IHJlc291cmNlIGF4cDgwOV9wZWtfcmVz b3VyY2VzW10gPSB7Cj4gIAlERUZJTkVfUkVTX0lSUV9OQU1FRChBWFA4MDlfSVJRX1BFS19SSVNf RURHRSwgIlBFS19EQlIiKSwKPiAgCURFRklORV9SRVNfSVJRX05BTUVEKEFYUDgwOV9JUlFfUEVL X0ZBTF9FREdFLCAiUEVLX0RCRiIpLAo+IEBAIC03MzAsNiArNzM1LDE3IEBAIHN0YXRpYyBjb25z dCBzdHJ1Y3QgbWZkX2NlbGwgYXhwODAzX2NlbGxzW10gPSB7Cj4gIAl7CS5uYW1lCQkJPSAiYXhw MjB4LXJlZ3VsYXRvciIgfSwKPiAgfTsKPiAgCj4gK3N0YXRpYyBjb25zdCBzdHJ1Y3QgbWZkX2Nl bGwgYXhwODA2X3NlbGZfd29ya2luZ19jZWxsc1tdID0gewo+ICsJewo+ICsJCS5uYW1lCQkJPSAi YXhwMjIxLXBlayIsCj4gKwkJLm51bV9yZXNvdXJjZXMJCT0gQVJSQVlfU0laRShheHA4MDZfcGVr X3Jlc291cmNlcyksCj4gKwkJLnJlc291cmNlcwkJPSBheHA4MDZfcGVrX3Jlc291cmNlcywKPiAr CX0sCj4gKwl7Cj4gKwkJLm5hbWUJCQk9ICJheHAyMHgtcmVndWxhdG9yIiwKPiArCX0sCj4gK307 CgpOaXQ6IFBsZWFzZSBwbGFjZSBzaW5nbGUgbGluZSBlbnRyaWVzIG9uIGEgc2luZ2xlIGxpbmUu ICBMaWtlIHRoaXM6CgoJeyAgIAkgIC5uYW1lCQkJPSAiYXhwMjB4LXJlZ3VsYXRvciIsIH0sCgpB ZnRlciB5b3UgaGF2ZSBtYWRlIHRoYXQgY2hhbmdlLCBwbGVhc2UgYWRkIG15OgoKRm9yIG15IG93 biByZWZlcmVuY2U6CiAgQWNrZWQtZm9yLU1GRC1ieTogTGVlIEpvbmVzIDxsZWUuam9uZXNAbGlu YXJvLm9yZz4KCi0tIApMZWUgSm9uZXMgW+adjueQvOaWr10KTGluYXJvIFNlcnZpY2VzIFRlY2hu aWNhbCBMZWFkCkxpbmFyby5vcmcg4pSCIE9wZW4gc291cmNlIHNvZnR3YXJlIGZvciBBUk0gU29D cwpGb2xsb3cgTGluYXJvOiBGYWNlYm9vayB8IFR3aXR0ZXIgfCBCbG9nCgpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxp bmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3Rz LmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==