From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH v7 5/6] mfd: cros_ec_dev: Add CEC sub-device registration Date: Wed, 4 Jul 2018 14:12:42 +0100 Message-ID: <20180704131242.GF496@dell> References: <1527841154-24832-1-git-send-email-narmstrong@baylibre.com> <1527841154-24832-6-git-send-email-narmstrong@baylibre.com> <20180704074717.GP20176@dell> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Neil Armstrong Cc: seanpaul@google.com, fparent@baylibre.com, airlied@linux.ie, sadolfsson@google.com, intel-gfx@lists.freedesktop.org, eballetbo@gmail.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, felixe@google.com, hans.verkuil@cisco.com, olof@lixom.net, bleung@google.com, darekm@google.com, linux-media@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCAwNCBKdWwgMjAxOCwgTmVpbCBBcm1zdHJvbmcgd3JvdGU6Cgo+IEhpIExlZSwKPiAK PiBPbiAwNC8wNy8yMDE4IDA5OjQ3LCBMZWUgSm9uZXMgd3JvdGU6Cj4gPiBPbiBGcmksIDAxIEp1 biAyMDE4LCBOZWlsIEFybXN0cm9uZyB3cm90ZToKPiA+IAo+ID4+IFRoZSBFQyBjYW4gZXhwb3Nl IGEgQ0VDIGJ1cywgdGh1cyBhZGQgdGhlIGNyb3MtZWMtY2VjIE1GRCBzdWItZGV2aWNlCj4gPj4g d2hlbiB0aGUgQ0VDIGZlYXR1cmUgYml0IGlzIHByZXNlbnQuCj4gPj4KPiA+PiBTaWduZWQtb2Zm LWJ5OiBOZWlsIEFybXN0cm9uZyA8bmFybXN0cm9uZ0BiYXlsaWJyZS5jb20+Cj4gPj4gUmV2aWV3 ZWQtYnk6IEVucmljIEJhbGxldGJvIGkgU2VycmEgPGVucmljLmJhbGxldGJvQGNvbGxhYm9yYS5j b20+Cj4gPj4gQWNrZWQtYnk6IEhhbnMgVmVya3VpbCA8aGFucy52ZXJrdWlsQGNpc2NvLmNvbT4K PiA+PiAtLS0KPiA+PiAgZHJpdmVycy9tZmQvY3Jvc19lY19kZXYuYyB8IDE2ICsrKysrKysrKysr KysrKysKPiA+PiAgMSBmaWxlIGNoYW5nZWQsIDE2IGluc2VydGlvbnMoKykKPiA+IAo+ID4gRm9y IG15IG93biByZWZlcmVuY2U6Cj4gPiAgIEFja2VkLWZvci1NRkQtYnk6IExlZSBKb25lcyA8bGVl LmpvbmVzQGxpbmFyby5vcmc+Cj4gPiAKPiAKPiBTaG91bGQgSSBrZWVwIHRoZXNlIEFja2VkLWZv ci1NRkQtYnkgZm9yIHRoZSB2OCA/CgpZZXMgcGxlYXNlLgoKLS0gCkxlZSBKb25lcyBb5p2O55C8 5pavXQpMaW5hcm8gU2VydmljZXMgVGVjaG5pY2FsIExlYWQKTGluYXJvLm9yZyDilIIgT3BlbiBz b3VyY2Ugc29mdHdhcmUgZm9yIEFSTSBTb0NzCkZvbGxvdyBMaW5hcm86IEZhY2Vib29rIHwgVHdp dHRlciB8IEJsb2cKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3Jn Cmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4 Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-wm0-f65.google.com ([74.125.82.65]:34841 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753003AbeGDNMr (ORCPT ); Wed, 4 Jul 2018 09:12:47 -0400 Received: by mail-wm0-f65.google.com with SMTP id v3-v6so2081209wmh.0 for ; Wed, 04 Jul 2018 06:12:46 -0700 (PDT) Date: Wed, 4 Jul 2018 14:12:42 +0100 From: Lee Jones To: Neil Armstrong Cc: airlied@linux.ie, hans.verkuil@cisco.com, olof@lixom.net, seanpaul@google.com, sadolfsson@google.com, felixe@google.com, bleung@google.com, darekm@google.com, marcheu@chromium.org, fparent@baylibre.com, dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, eballetbo@gmail.com Subject: Re: [PATCH v7 5/6] mfd: cros_ec_dev: Add CEC sub-device registration Message-ID: <20180704131242.GF496@dell> References: <1527841154-24832-1-git-send-email-narmstrong@baylibre.com> <1527841154-24832-6-git-send-email-narmstrong@baylibre.com> <20180704074717.GP20176@dell> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: linux-media-owner@vger.kernel.org List-ID: On Wed, 04 Jul 2018, Neil Armstrong wrote: > Hi Lee, > > On 04/07/2018 09:47, Lee Jones wrote: > > On Fri, 01 Jun 2018, Neil Armstrong wrote: > > > >> The EC can expose a CEC bus, thus add the cros-ec-cec MFD sub-device > >> when the CEC feature bit is present. > >> > >> Signed-off-by: Neil Armstrong > >> Reviewed-by: Enric Balletbo i Serra > >> Acked-by: Hans Verkuil > >> --- > >> drivers/mfd/cros_ec_dev.c | 16 ++++++++++++++++ > >> 1 file changed, 16 insertions(+) > > > > For my own reference: > > Acked-for-MFD-by: Lee Jones > > > > Should I keep these Acked-for-MFD-by for the v8 ? Yes please. -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog