Re: [PATCH] x86/altp2m: Add a subop for obtaining the mem access of a page

From: Adrian Pop <apop@bitdefender.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wei.liu2@citrix.com>,
	Razvan Cojocaru <rcojocaru@bitdefender.com>,
	George Dunlap <George.Dunlap@eu.citrix.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Ian Jackson <Ian.Jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>,
	Julien Grall <julien.grall@arm.com>,
	tamas@tklengyel.com, xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH] x86/altp2m: Add a subop for obtaining the mem access of a page
Date: Wed, 4 Jul 2018 16:20:15 +0300	[thread overview]
Message-ID: <20180704132015.GA12259@hel> (raw)
In-Reply-To: <20180704122045.GA3652@hel>

On Wed, Jul 04, 2018 at 03:20:45PM +0300, Adrian POP wrote:
> On Fri, Jun 29, 2018 at 09:38:58AM -0600, Jan Beulich wrote:
> > > --- a/xen/arch/x86/mm/mem_access.c
> > > +++ b/xen/arch/x86/mm/mem_access.c
> > > @@ -32,17 +32,10 @@
> > >  
> > >  #include "mm-locks.h"
> > >  
> > > -/*
> > > - * Get access type for a gfn.
> > > - * If gfn == INVALID_GFN, gets the default access type.
> > > - */
> > > -static int _p2m_get_mem_access(struct p2m_domain *p2m, gfn_t gfn,
> > > -                               xenmem_access_t *access)
> > > +static int p2m_access_to_xenmem_access(struct p2m_domain *p2m,
> > 
> > This is not even p2m code - why the p2m_ prefix?
> 
> There's indeed no reason for this to have the p2m_ prefix.  Will remove
> it.

Oh I remember now.  The p2m_ prefix was added there because the helper
function converts a p2m_access_t to a xenmem_access_t, so
p2m_access_to_xenmem_access().  Took the naming from the complementary
function, xenmem_access_to_p2m_access().  I could add a comment to
clarify this.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel