All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: kys@microsoft.com
Cc: x86@kernel.org, gregkh@linuxfoundation.org,
	linux-kernel@vger.kernel.org, devel@linuxdriverproject.org,
	olaf@aepfle.de, apw@canonical.com, jasowang@redhat.com,
	tglx@linutronix.de, hpa@zytor.com, sthemmin@microsoft.com,
	Michael.H.Kelley@microsoft.com, vkuznets@redhat.com
Subject: Re: [PATCH 1/1] X86/Hyper-V:: Fix the circular dependency in IPI enlightenment.
Date: Wed, 4 Jul 2018 18:10:39 +0200	[thread overview]
Message-ID: <20180704161039.GA23658@gmail.com> (raw)
In-Reply-To: <20180703230155.15160-1-kys@linuxonhyperv.com>


* kys@linuxonhyperv.com <kys@linuxonhyperv.com> wrote:

> From: "K. Y. Srinivasan" <kys@microsoft.com>
> 
> The IPI hypercalls depend on being able to map the Linux notion of CPU ID
> to the hypervisor's notion of the CPU ID. The array hv_vp_index[] provides
> this mapping. Code for populating this array depends on the IPI functionality.
> Break this circular dependency.
> 
> Fixes: 68bb7bfb7985 ("X86/Hyper-V: Enable IPI enlightenments")
> 
> Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
> Tested-by: Michael Kelley <mikelley@microsoft.com>
> ---
>  arch/x86/hyperv/hv_apic.c       | 5 +++++
>  arch/x86/hyperv/hv_init.c       | 5 ++++-
>  arch/x86/include/asm/mshyperv.h | 2 ++
>  3 files changed, 11 insertions(+), 1 deletion(-)

Ugh, this patch wasn't even build tested, on 64-bit allyes/allmodconfig:

 arch/x86/hyperv/hv_apic.c: In function ‘__send_ipi_mask’:
 arch/x86/hyperv/hv_apic.c:171:4: error: label ‘ipi_mask_done’ used but not defined
 scripts/Makefile.build:317: recipe for target 'arch/x86/hyperv/hv_apic.o' failed
 make[2]: *** [arch/x86/hyperv/hv_apic.o] Error 1

Thanks,

	Ingo

  parent reply	other threads:[~2018-07-04 16:10 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-03 23:01 [PATCH 1/1] X86/Hyper-V:: Fix the circular dependency in IPI enlightenment kys
2018-07-04  8:54 ` [tip:x86/urgent] x86/hyper-v: " tip-bot for K. Y. Srinivasan
2018-07-04  9:13 ` [PATCH 1/1] X86/Hyper-V:: " Vitaly Kuznetsov
2018-07-04 16:10 ` Ingo Molnar [this message]
2018-07-05 15:01   ` KY Srinivasan
2018-07-05 15:38     ` Ingo Molnar
2018-07-05 21:11       ` KY Srinivasan
2018-07-05 22:23         ` Ingo Molnar
2018-07-05 22:46           ` Thomas Gleixner
2018-07-06  3:59             ` KY Srinivasan
2018-07-06  8:53               ` Thomas Gleixner
2018-07-06 10:42                 ` Thomas Gleixner
2018-07-06 16:12                   ` Michael Kelley (EOSG)
2018-07-06 17:01                     ` Thomas Gleixner
2018-07-06 18:05                   ` KY Srinivasan
2018-07-06 10:00             ` Ingo Molnar
2018-07-06 10:42 ` [tip:x86/hyperv] x86/hyper-v: " tip-bot for K. Y. Srinivasan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180704161039.GA23658@gmail.com \
    --to=mingo@kernel.org \
    --cc=Michael.H.Kelley@microsoft.com \
    --cc=apw@canonical.com \
    --cc=devel@linuxdriverproject.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hpa@zytor.com \
    --cc=jasowang@redhat.com \
    --cc=kys@microsoft.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=olaf@aepfle.de \
    --cc=sthemmin@microsoft.com \
    --cc=tglx@linutronix.de \
    --cc=vkuznets@redhat.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.