Re: [igt-dev] [PATCH i-g-t 3/7] lib/rendercopy: Set the upper 32bits of surface base address on gen8+

From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t 3/7] lib/rendercopy: Set the upper 32bits of surface base address on gen8+
Date: Wed, 4 Jul 2018 21:47:05 +0300	[thread overview]
Message-ID: <20180704184705.GU5565@intel.com> (raw)
In-Reply-To: <153072249710.15734.16515204671492559138@skylake.alporthouse.com>

On Wed, Jul 04, 2018 at 05:41:37PM +0100, Chris Wilson wrote:
> Quoting Ville Syrjala (2018-07-04 17:16:42)
> > diff --git a/lib/rendercopy_gen8.c b/lib/rendercopy_gen8.c
> > index 4406a0a0e6eb..5a9bf32e6b9b 100644
> > --- a/lib/rendercopy_gen8.c
> > +++ b/lib/rendercopy_gen8.c
> > @@ -172,7 +172,8 @@ gen8_bind_buf(struct intel_batchbuffer *batch,
> >         else if (buf->tiling == I915_TILING_Y)
> >                 ss->ss0.tiled_mode = 3;
> >  
> > -       ss->ss8.base_addr = buf->bo->offset;
> > +       ss->ss8.base_addr = buf->bo->offset64;
> > +       ss->ss9.base_addr_hi = buf->bo->offset64 >> 32;
> 
> To be pedantic, we might want to use gen8_canonical_addr(x)
> { return (int64_t)((uint64_t)x << (63-47)) >> (63-47); }

Looks to me like bo->offset64 should already be a canonical
address as that's what the kernel hands back out after relocating.
Or am I missing something?

-- 
Ville Syrjälä
Intel
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev