All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Dan Williams <dan.j.williams@intel.com>
Cc: David Rientjes <rientjes@google.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Wei Yang <richard.weiyang@gmail.com>,
	kbuild test robot <lkp@intel.com>,
	x86@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/numa_emulation: Fix uniform size build failure
Date: Thu, 5 Jul 2018 10:24:35 +0200	[thread overview]
Message-ID: <20180705082435.GA29656@gmail.com> (raw)
In-Reply-To: <153065162801.12250.4860144566061573514.stgit@dwillia2-desk3.amr.corp.intel.com>


* Dan Williams <dan.j.williams@intel.com> wrote:

> The calculation of a uniform numa-node size attempted to perform
> division with a 64-bit diviser leading to the following failure on
> 32-bit:
> 
>     arch/x86/mm/numa_emulation.o: In function `split_nodes_size_interleave_uniform':
>     arch/x86/mm/numa_emulation.c:239: undefined reference to `__udivdi3'
> 
> Convert the implementation to do the division in terms of pages and then
> shift the result back to an absolute physical address.
> 
> Fixes: 93e738834fcc ("x86/numa_emulation: Introduce uniform split capability")
> Cc: David Rientjes <rientjes@google.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Wei Yang <richard.weiyang@gmail.com>
> Reported-by: kbuild test robot <lkp@intel.com>
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>

I'm still getting this link failure on 32-bit kernels:

 arch/x86/mm/numa_emulation.o: In function `split_nodes_size_interleave_uniform.constprop.1':
 numa_emulation.c:(.init.text+0x669): undefined reference to `__udivdi3'
 Makefile:1005: recipe for target 'vmlinux' failed

config attached.

These numa_emulation changes are a bit of a trainwreck - I'm removing both 
num_emulation commits from -tip for now, could you please resubmit a fixed/tested 
combo version?

Thanks,

	Ingo

  parent reply	other threads:[~2018-07-05  8:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-03 21:00 [PATCH] x86/numa_emulation: Fix uniform size build failure Dan Williams
2018-07-04 16:15 ` [tip:x86/cpu] " tip-bot for Dan Williams
2018-07-05  8:24 ` Ingo Molnar [this message]
2018-07-06  2:55   ` [PATCH] " Dan Williams
2018-07-06 10:03     ` Ingo Molnar
2018-07-06 16:06       ` Dan Williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180705082435.GA29656@gmail.com \
    --to=mingo@kernel.org \
    --cc=dan.j.williams@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lkp@intel.com \
    --cc=richard.weiyang@gmail.com \
    --cc=rientjes@google.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.