From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44114) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fb0OU-0006dC-M5 for qemu-devel@nongnu.org; Thu, 05 Jul 2018 05:17:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fb0OR-0003kO-Fy for qemu-devel@nongnu.org; Thu, 05 Jul 2018 05:17:42 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:38614 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fb0OR-0003hs-9d for qemu-devel@nongnu.org; Thu, 05 Jul 2018 05:17:39 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E74F787928 for ; Thu, 5 Jul 2018 09:17:38 +0000 (UTC) Date: Thu, 5 Jul 2018 17:17:34 +0800 From: Peter Xu Message-ID: <20180705091734.GC1389@xz-mi> References: <20180704084507.14560-1-peterx@redhat.com> <20180704084507.14560-4-peterx@redhat.com> <871sciax9a.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <871sciax9a.fsf@dusky.pond.sub.org> Subject: Re: [Qemu-devel] [PATCH 3/9] qapi: remove error checks for event emission List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-devel@nongnu.org, "Dr . David Alan Gilbert" , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau On Thu, Jul 05, 2018 at 10:43:13AM +0200, Markus Armbruster wrote: > Peter Xu writes: > > > In the whole QAPI event emission code we're passing in an Error* object > > along the whole stack. That's never useful since it never fails after > > all. Remove that. > > > > Then, remove that parameter from all the callers to send an event. > > > > Suggested-by: Eric Blake > > Suggested-by: Markus Armbruster > > Signed-off-by: Peter Xu > [...] > > diff --git a/scripts/qapi/events.py b/scripts/qapi/events.py > > index 5657524688..3953dc9837 100644 > > --- a/scripts/qapi/events.py > > +++ b/scripts/qapi/events.py > > @@ -18,7 +18,7 @@ from qapi.common import * > > def build_event_send_proto(name, arg_type, boxed): > > return 'void qapi_event_send_%(c_name)s(%(param)s)' % { > > 'c_name': c_name(name.lower()), > > - 'param': build_params(arg_type, boxed, 'Error **errp')} > > + 'param': build_params(arg_type, boxed, "")} > > Use ' instead of " for consistency. > > But let's make @extra optional in the previous patch (default it to > None), so this spot becomes simpler. Will do. > > > > > > > def gen_event_send_decl(name, arg_type, boxed): > > @@ -70,7 +70,6 @@ def gen_event_send(name, arg_type, boxed, event_enum_name): > > %(proto)s > > { > > QDict *qmp; > > - Error *err = NULL; > > QMPEventFuncEmit emit; > > ''', > > proto=build_event_send_proto(name, arg_type, boxed)) > > @@ -103,45 +102,35 @@ def gen_event_send(name, arg_type, boxed, event_enum_name): > > ''') > > if not arg_type.is_implicit(): > > ret += mcgen(''' > > - visit_type_%(c_name)s(v, "%(name)s", &arg, &err); > > + visit_type_%(c_name)s(v, "%(name)s", &arg, NULL); > > &error_abort, please. This should never fail, and when it does, > something's seriously wrong. Ok. > > > ''', > > name=name, c_name=arg_type.c_name()) > > else: > > ret += mcgen(''' > > > > - visit_start_struct(v, "%(name)s", NULL, 0, &err); > > - if (err) { > > - goto out; > > - } > > - visit_type_%(c_name)s_members(v, ¶m, &err); > > - if (!err) { > > - visit_check_struct(v, &err); > > - } > > + visit_start_struct(v, "%(name)s", NULL, 0, NULL); > > + visit_type_%(c_name)s_members(v, ¶m, NULL); > > + visit_check_struct(v, NULL); > > Likewise. Done. Thanks, -- Peter Xu