All of lore.kernel.org
 help / color / mirror / Atom feed
From: Philipp Rudo <prudo@linux.ibm.com>
To: Dave Young <dyoung@redhat.com>
Cc: x86@kernel.org, Andrew Morton <akpm@linux-foundation.org>,
	Ingo Molnar <mingo@redhat.com>,
	kexec@lists.infradead.org, Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 0/1] x86/purgatory: Fix Makefile bug
Date: Thu, 5 Jul 2018 10:43:32 +0200	[thread overview]
Message-ID: <20180705104332.0ba5c9ab@ThinkPad> (raw)
In-Reply-To: <20180705064620.GA24455@dhcp-128-65.nay.redhat.com>

Hi Dave,

On Thu, 5 Jul 2018 14:46:20 +0800
Dave Young <dyoung@redhat.com> wrote:

> On 07/04/18 at 01:00pm, Philipp Rudo wrote:
> > Hi everybody,
> > 
> > when i moved the purgatories sha256 implementation to common code, i forgot
> > to add FORCE to the new Makefile target. This patch fixes it.  
> 
> Hi Philipp,
> 
> Do you have the exact steps of how to reproduce your problem?

I only tested it on s390, but on x86 it should work the same way.

- Build the kernel without the fix
- Add some flag to the purgatories KBUILD_CFLAGS,I used
  -fno-asynchronous-unwind-tables
- Re-build the kernel

When you look at make's output you see that sha256.o is not re-build in the
last step. Also readelf -S still shows the .eh_frame section for sha256.o.

With the fix sha256.o is re-build in the last step.

Hope that helps.

Thanks
Philipp

> > 
> > Note: There is an equivalent bug in the s390 purgatory. The fix for that
> > will go upstream via Martin.
> > 
> > Thanks
> > Philipp
> > 
> > Philipp Rudo (1):
> >   x86/purgatory: Add missing FORCE to Makefile target
> > 
> >  arch/x86/purgatory/Makefile | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > -- 
> > 2.16.4
> >   
> 
> Thanks
> Dave
> 


_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

  reply	other threads:[~2018-07-05  8:43 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-04 11:00 [PATCH 0/1] x86/purgatory: Fix Makefile bug Philipp Rudo
2018-07-04 11:00 ` [PATCH 1/1] x86/purgatory: Add missing FORCE to Makefile target Philipp Rudo
2018-07-05  6:46 ` [PATCH 0/1] x86/purgatory: Fix Makefile bug Dave Young
2018-07-05  8:43   ` Philipp Rudo [this message]
2018-07-06  8:30     ` Dave Young
2018-07-06  8:54       ` Philipp Rudo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180705104332.0ba5c9ab@ThinkPad \
    --to=prudo@linux.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=dyoung@redhat.com \
    --cc=kexec@lists.infradead.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.