All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Andrey Grodzovsky <Andrey.Grodzovsky@amd.com>
Cc: alexander.deucher@amd.com, harry.wentland@amd.com,
	michel.daenzer@amd.com, shirish.s@amd.com,
	stable@vger.kernel.org, stable-commits@vger.kernel.org
Subject: Re: Patch "drm/amd/display: release spinlock before committing updates to stream" has been added to the 4.17-stable tree
Date: Thu, 5 Jul 2018 18:06:32 +0200	[thread overview]
Message-ID: <20180705160632.GA7911@kroah.com> (raw)
In-Reply-To: <a2be8c4a-e3f2-130a-7fae-c33334505e2f@amd.com>

On Thu, Jul 05, 2018 at 12:05:09PM -0400, Andrey Grodzovsky wrote:
> This patch is wrong as noted by MIchel a while ago - quote from his review
> of the patch.
> 
> "Actually, pflip_status should really only be set to AMDGPU_FLIP_SUBMITTED
> after the flip has been programmed to the hardware, at least as far as the
> lock holder is concerned. That's why the code was previously holding the
> lock until after the dc_commit_updates_for_stream call. Otherwise, it's at
> least theoretically possible that either:
> 
> * dm_pflip_high_irq is called before dc_commit_updates_for_stream, but sees
> flip_status == AMDGPU_FLIP_SUBMITTED and sends the event to userspace
> prematurely
> 
> * dm_pflip_high_irq is called after dc_commit_updates_for_stream, but sees
> flip_status != AMDGPU_FLIP_SUBMITTED, so it incorrectly doesn't send the
> event to userspace "
> 
> It shouldn't go in.

Is there a fix for this in Linus's tree for these problems?
If not, why not?  If so, what is that git commit id?

thanks,

greg k-h

  reply	other threads:[~2018-07-05 16:06 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1530806367175127@kroah.com>
2018-07-05 16:05 ` Patch "drm/amd/display: release spinlock before committing updates to stream" has been added to the 4.17-stable tree Andrey Grodzovsky
2018-07-05 16:06   ` Greg KH [this message]
2018-07-05 16:09     ` Andrey Grodzovsky
2018-07-05 17:41       ` Harry Wentland
2018-07-06  6:26         ` S, Shirish
2018-07-06 13:37           ` Andrey Grodzovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180705160632.GA7911@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=Andrey.Grodzovsky@amd.com \
    --cc=alexander.deucher@amd.com \
    --cc=harry.wentland@amd.com \
    --cc=michel.daenzer@amd.com \
    --cc=shirish.s@amd.com \
    --cc=stable-commits@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.