All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Jan Kara <jack@suse.cz>, Theodore Tso <tytso@mit.edu>,
	stable <stable@vger.kernel.org>
Subject: Re: FAILED: patch "[PATCH] ext4: do not update s_last_mounted of a frozen fs" failed to apply to 4.17-stable tree
Date: Thu, 5 Jul 2018 18:27:01 +0200	[thread overview]
Message-ID: <20180705162701.GC18499@kroah.com> (raw)
In-Reply-To: <CAOQ4uxj7GkK5eVVhan5OiRiwpZ6Ew-FxH+gYVAZpitocr0WD+A@mail.gmail.com>

On Fri, Jun 22, 2018 at 12:25:43AM +0300, Amir Goldstein wrote:
> On Fri, Jun 22, 2018 at 12:15 AM,  <gregkh@linuxfoundation.org> wrote:
> >
> > The patch below does not apply to the 4.17-stable tree.
> 
> There is a [backport hint] at the end of the commit message.
> Need to take the 2 prep commits.
> Same for all stable branches.
> 
> Cheers,
> Amir.
> 
> > If someone wants it applied there, or to any other stable or longterm
> > tree, then please email the backport, including the original git commit
> > id to <stable@vger.kernel.org>.
> >
> > thanks,
> >
> > greg k-h
> >
> > ------------------ original commit in Linus's tree ------------------
> >
> > From db6516a5e7ddb6dc72d167b920f2f272596ea22d Mon Sep 17 00:00:00 2001
> > From: Amir Goldstein <amir73il@gmail.com>
> > Date: Sun, 13 May 2018 22:54:44 -0400
> > Subject: [PATCH] ext4: do not update s_last_mounted of a frozen fs
> >
> > If fs is frozen after mount and before the first file open, the
> > update of s_last_mounted bypasses freeze protection and prints out
> > a WARNING splat:
> >
> > $ mount /vdf
> > $ fsfreeze -f /vdf
> > $ cat /vdf/foo
> >
> > [   31.578555] WARNING: CPU: 1 PID: 1415 at
> > fs/ext4/ext4_jbd2.c:53 ext4_journal_check_start+0x48/0x82
> >
> > [   31.614016] Call Trace:
> > [   31.614997]  __ext4_journal_start_sb+0xe4/0x1a4
> > [   31.616771]  ? ext4_file_open+0xb6/0x189
> > [   31.618094]  ext4_file_open+0xb6/0x189
> >
> > If fs is frozen, skip s_last_mounted update.
> >
> > [backport hint: to apply to stable tree, need to apply also patches
> >  vfs: add the sb_start_intwrite_trylock() helper
> >  ext4: factor out helper ext4_sample_last_mounted()]

For "hints", can you provide the git commit id in the future so I don't
have to dig them out myself?

thanks,

greg k-h

  parent reply	other threads:[~2018-07-05 16:27 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-21 21:15 FAILED: patch "[PATCH] ext4: do not update s_last_mounted of a frozen fs" failed to apply to 4.17-stable tree gregkh
2018-06-21 21:25 ` Amir Goldstein
2018-06-22  0:06   ` Greg KH
2018-07-05 16:27   ` Greg KH [this message]
2018-07-05 16:29     ` Greg KH
2018-07-05 17:07       ` Amir Goldstein
2018-07-06  8:45         ` Amir Goldstein
2018-07-10 12:24           ` Greg KH
2018-07-10 12:50             ` Amir Goldstein
2018-07-09 13:52         ` Jan Kara
2018-07-10 12:58           ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180705162701.GC18499@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=amir73il@gmail.com \
    --cc=jack@suse.cz \
    --cc=stable@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.