From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/selftests: Fixup recursive MI_BB_START for gen3
Date: Thu, 5 Jul 2018 19:29:48 +0300 [thread overview]
Message-ID: <20180705162948.GD5565@intel.com> (raw)
In-Reply-To: <20180705153230.32656-1-chris@chris-wilson.co.uk>
On Thu, Jul 05, 2018 at 04:32:30PM +0100, Chris Wilson wrote:
> There's no magic bit0 for gen3, it's the same dword length parameter as
> elsewhere and needs to be zero.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/selftests/i915_request.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/selftests/i915_request.c b/drivers/gpu/drm/i915/selftests/i915_request.c
> index 675017bf59dd..cc27edc40356 100644
> --- a/drivers/gpu/drm/i915/selftests/i915_request.c
> +++ b/drivers/gpu/drm/i915/selftests/i915_request.c
> @@ -594,11 +594,8 @@ static struct i915_vma *recursive_batch(struct drm_i915_private *i915)
> } else if (gen >= 6) {
> *cmd++ = MI_BATCH_BUFFER_START | 1 << 8;
> *cmd++ = lower_32_bits(vma->node.start);
> - } else if (gen >= 4) {
> - *cmd++ = MI_BATCH_BUFFER_START | MI_BATCH_GTT;
> - *cmd++ = lower_32_bits(vma->node.start);
> } else {
> - *cmd++ = MI_BATCH_BUFFER_START | MI_BATCH_GTT | 1;
> + *cmd++ = MI_BATCH_BUFFER_START | MI_BATCH_GTT;
> *cmd++ = lower_32_bits(vma->node.start);
> }
> *cmd++ = MI_BATCH_BUFFER_END; /* terminate early in case of error */
> --
> 2.18.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2018-07-05 16:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-05 15:32 [PATCH] drm/i915/selftests: Fixup recursive MI_BB_START for gen3 Chris Wilson
2018-07-05 16:29 ` Ville Syrjälä [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180705162948.GD5565@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.