All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Laszlo Ersek <lersek@redhat.com>
Cc: "Richard W.M. Jones" <rjones@redhat.com>,
	qemu-devel@nongnu.org, berrange@redhat.com, jferlan@redhat.com
Subject: Re: [Qemu-devel] Byte ordering of VM Generation ID in Windows VMs
Date: Thu, 5 Jul 2018 20:34:00 +0300	[thread overview]
Message-ID: <20180705202215-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <eba002c2-a50d-7252-65fa-104194e31fe8@redhat.com>

On Thu, Jul 05, 2018 at 07:15:34PM +0200, Laszlo Ersek wrote:
> > It has to be said that after reading the spec again [the MSFT spec,
> > not qemu's spec] and what other hypervisors are doing, I'm not sure
> > qemu is doing the right thing here.
> 
> That's the thing about specs -- interpretation. I've read the vmgenid
> spec several times as well, and I've always understood it as Microsoft
> meaning UUID / GUID as a primary representation for VMGENID. I may have
> been biased by UUID/GUID usage in UEFI.
> 
> When the feature was being developed for QEMU, we struggled with the
> interpretation of a good number of other bits as well; hence the
> "Requirements" section of QEMU's spec: "this is how we understood it".
> Without an open list to discuss things with Microsoft, sometimes we can
> only guess what is a "likely faithful" interpretation, and test it in
> practice.
> 
> I still believe QEMU's current interpretation is the right one; but I
> can't prove it.
> 
> Laszlo

Well it does seem that at least some guest code wants a counter
there. So if someone posts a patch adding a count property there
to be stored in LE format, plus a unit test - I'll merge it, even
though it does not look like libvirt wants that.

-- 
MST

      reply	other threads:[~2018-07-05 17:34 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-05 12:39 [Qemu-devel] Byte ordering of VM Generation ID in Windows VMs Richard W.M. Jones
2018-07-05 12:52 ` Richard W.M. Jones
2018-07-05 13:54   ` Michael S. Tsirkin
2018-07-05 14:11     ` Richard W.M. Jones
2018-07-09  7:36       ` Richard W.M. Jones
2018-07-09  9:05         ` Laszlo Ersek
2018-07-09  9:11           ` Richard W.M. Jones
2018-07-09 15:50         ` Richard W.M. Jones
2018-07-05 14:20   ` Laszlo Ersek
2018-07-05 16:43     ` Richard W.M. Jones
2018-07-05 17:10       ` Michael S. Tsirkin
2018-07-05 20:59         ` Richard W.M. Jones
2018-07-05 17:13       ` Daniel P. Berrangé
2018-07-05 17:15       ` Laszlo Ersek
2018-07-05 17:34         ` Michael S. Tsirkin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180705202215-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=berrange@redhat.com \
    --cc=jferlan@redhat.com \
    --cc=lersek@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rjones@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.