Re: [PATCH] drm/i915/selftests: Skip over live context testing when wedged

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Thu, Jul 05, 2018 at 03:58:45PM +0100, Chris Wilson wrote:
> If the GPU is terminally wedged we cannot submit any requests into a
> context, completely unfulfilling our purpose of doing so. As this
> expectedly fails, skip over the test.
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
>  drivers/gpu/drm/i915/selftests/i915_gem_context.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/selftests/i915_gem_context.c b/drivers/gpu/drm/i915/selftests/i915_gem_context.c
> index cc848ceeb3c3..0b36265a0f96 100644
> --- a/drivers/gpu/drm/i915/selftests/i915_gem_context.c
> +++ b/drivers/gpu/drm/i915/selftests/i915_gem_context.c
> @@ -599,6 +599,9 @@ int i915_gem_context_live_selftests(struct drm_i915_private *dev_priv)
>  	bool fake_alias = false;
>  	int err;
>  
> +	if (i915_terminally_wedged(&dev_priv->gpu_error))
> +		return 0;
> +

I wonder if this could mask a real failure under the skips?

but if actual error is already captured somewhere else than probably better to avoid the noise
of a ENOTRECOVERABLE or whatever...

>  	/* Install a fake aliasing gtt for exercise */
>  	if (USES_PPGTT(dev_priv) && !dev_priv->mm.aliasing_ppgtt) {
>  		mutex_lock(&dev_priv->drm.struct_mutex);
> -- 
> 2.18.0
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx