From: Sowmini Varadhan <sowmini.varadhan@oracle.com>
To: Santosh Shilimkar <santosh.shilimkar@oracle.com>, davem@davemloft.net
Cc: Ka-Cheong Poon <ka-cheong.poon@oracle.com>,
netdev@vger.kernel.org, rds-devel@oss.oracle.com
Subject: Re: [PATCH v2 net-next 1/3] rds: Changing IP address internal representation to struct in6_addr
Date: Fri, 6 Jul 2018 06:15:05 -0400 [thread overview]
Message-ID: <20180706101505.GA32098@oracle.com> (raw)
In-Reply-To: <6a7b0951-d950-1555-a5b2-622d6f7b9f8f@oracle.com>
On (07/06/18 17:08), Ka-Cheong Poon wrote:
> >Hmm. Why do you need to include tcp header in ib transport
> >code ? If there is any common function just move to core
> >common file and use it.
>
> I think it can be removed as it is left over from earlier
> changes when the IB IPv6 listener port was RDS_TCP_PORT.
> Now all the port definitions are in rds.h.
Transport specific information such as port numbers should not
be smeared into the common rds-module. Please fix that.
If IB is also piggybacking on port 16385 (why?), please use your
own definitions for it in IB specific header files.
Santosh, David, I have to NACK this if it is not changed.
--Sowmini
next prev parent reply other threads:[~2018-07-06 10:15 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-27 10:23 [PATCH v2 net-next 0/3] rds: IPv6 support Ka-Cheong Poon
2018-06-27 10:23 ` [PATCH v2 net-next 1/3] rds: Changing IP address internal representation to struct in6_addr Ka-Cheong Poon
2018-06-30 8:50 ` David Miller
2018-07-03 14:02 ` Ka-Cheong Poon
2018-07-05 17:58 ` Santosh Shilimkar
2018-07-06 9:08 ` Ka-Cheong Poon
2018-07-06 10:15 ` Sowmini Varadhan [this message]
2018-07-06 15:08 ` Ka-Cheong Poon
2018-07-06 15:25 ` Sowmini Varadhan
2018-07-06 17:26 ` Santosh Shilimkar
2018-07-09 12:26 ` Ka-Cheong Poon
2018-07-06 14:55 ` santosh.shilimkar
2018-06-27 10:23 ` [PATCH v2 net-next 2/3] rds: Enable RDS IPv6 support Ka-Cheong Poon
2018-06-27 10:23 ` [PATCH v2 net-next 3/3] rds: Extend RDS API for " Ka-Cheong Poon
2018-07-05 17:44 ` [PATCH v2 net-next 0/3] rds: " Sowmini Varadhan
2018-07-06 14:36 ` Ka-Cheong Poon
2018-07-06 15:14 ` Sowmini Varadhan
2018-07-09 12:24 ` Ka-Cheong Poon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180706101505.GA32098@oracle.com \
--to=sowmini.varadhan@oracle.com \
--cc=davem@davemloft.net \
--cc=ka-cheong.poon@oracle.com \
--cc=netdev@vger.kernel.org \
--cc=rds-devel@oss.oracle.com \
--cc=santosh.shilimkar@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.