From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from muru.com ([72.249.23.125]:50488 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753519AbeGFKfp (ORCPT ); Fri, 6 Jul 2018 06:35:45 -0400 Date: Fri, 6 Jul 2018 03:35:41 -0700 From: Tony Lindgren To: Faiz Abbas Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, robh+dt@kernel.org, bcousson@baylibre.com, paul@pwsan.com, t-kristo@ti.com, mark.rutland@arm.com Subject: Re: [PATCH v4 4/6] bus: ti-sysc: Add support for software reset Message-ID: <20180706103541.GC112168@atomide.com> References: <20180705142319.19583-1-faiz_abbas@ti.com> <20180705142319.19583-5-faiz_abbas@ti.com> <20180705154758.GA112168@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: Sender: linux-clk-owner@vger.kernel.org List-ID: * Faiz Abbas [180706 10:05]: > Hi, > > On Thursday 05 July 2018 09:17 PM, Tony Lindgren wrote: > > * Faiz Abbas [180705 14:24]: > >> +static int sysc_reset(struct sysc *ddata) > >> +{ > >> + int offset = ddata->offsets[SYSC_SYSCONFIG]; > >> + int val = sysc_read(ddata, offset); > > > > Can you please just warn and return early for now if no > > syss_mask is specified? Otherwise we'll have mysterious > > errors if somebody leaves out "ti,hwmods" for module types > > we do not yet support reset for. > > RESET write to sysconfig can still happen even if there's no syss_mask > right? Not all modules need to poll on reset status. It can but we currently don't have anything similar to srst_udelay like we have in _ocp_softreset(). And we don't currently have suport for sysc reset done bit. So we want to warn and return error except in the known working case for now. Regards, Tony From mboxrd@z Thu Jan 1 00:00:00 1970 From: tony@atomide.com (Tony Lindgren) Date: Fri, 6 Jul 2018 03:35:41 -0700 Subject: [PATCH v4 4/6] bus: ti-sysc: Add support for software reset In-Reply-To: References: <20180705142319.19583-1-faiz_abbas@ti.com> <20180705142319.19583-5-faiz_abbas@ti.com> <20180705154758.GA112168@atomide.com> Message-ID: <20180706103541.GC112168@atomide.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org * Faiz Abbas [180706 10:05]: > Hi, > > On Thursday 05 July 2018 09:17 PM, Tony Lindgren wrote: > > * Faiz Abbas [180705 14:24]: > >> +static int sysc_reset(struct sysc *ddata) > >> +{ > >> + int offset = ddata->offsets[SYSC_SYSCONFIG]; > >> + int val = sysc_read(ddata, offset); > > > > Can you please just warn and return early for now if no > > syss_mask is specified? Otherwise we'll have mysterious > > errors if somebody leaves out "ti,hwmods" for module types > > we do not yet support reset for. > > RESET write to sysconfig can still happen even if there's no syss_mask > right? Not all modules need to poll on reset status. It can but we currently don't have anything similar to srst_udelay like we have in _ocp_softreset(). And we don't currently have suport for sysc reset done bit. So we want to warn and return error except in the known working case for now. Regards, Tony