From: "Michael S. Tsirkin" <mst@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: "Peter Xu" <peterx@redhat.com>,
"Alex Williamson" <alex.williamson@redhat.com>,
"Cédric Le Goater" <clg@kaod.org>,
qemu-devel@nongnu.org,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>
Subject: Re: [Qemu-devel] [PATCH] pci: remove pci_del_option_rom()
Date: Fri, 6 Jul 2018 19:25:04 +0300 [thread overview]
Message-ID: <20180706192326-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <9ae66133-86a6-72d8-cd66-f27592caffe9@redhat.com>
On Fri, Jul 06, 2018 at 05:55:23PM +0200, Paolo Bonzini wrote:
> On 06/07/2018 03:51, Peter Xu wrote:
> >
> > A question about memory region auto destruction (which might not
> > related to this patch): I see that we have object_property_add_child()
> > in memory_region_do_init() to achieve the auto destruction but only if
> > the "name" of memory region is specified. Could we just do that
> > unconditionally (though we might of course need to generate some of
> > the names), or is there a reason not to do so?
>
> I'm not sure actually if there are still regions without a name...
>
> Paolo
Answer to Peter's question would be a yes then?
With all the autodestruct I'm unsure when is calling vmstate_unregister_ram appropriate.
Is it necessary to invoke that from pci any longer?
--
MST
next prev parent reply other threads:[~2018-07-06 16:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-05 18:11 [Qemu-devel] [PATCH] pci: remove pci_del_option_rom() Cédric Le Goater
2018-07-05 19:11 ` Michael S. Tsirkin
2018-07-05 20:23 ` Cédric Le Goater
2018-07-05 19:30 ` Alex Williamson
2018-07-05 21:44 ` Paolo Bonzini
2018-07-06 1:51 ` Peter Xu
2018-07-06 15:55 ` Paolo Bonzini
2018-07-06 16:25 ` Michael S. Tsirkin [this message]
2018-07-06 16:40 ` Cédric Le Goater
2018-07-06 17:06 ` Paolo Bonzini
2018-07-06 17:17 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180706192326-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=clg@kaod.org \
--cc=marcel.apfelbaum@gmail.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.