From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH iproute2] tc: Fix output of ip attributes Date: Sat, 7 Jul 2018 10:00:13 -0700 Message-ID: <20180707100013.660a076c@xeon-e3> References: <1530622472-30156-1-git-send-email-roid@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, Jiri Pirko , Or Gerlitz To: Roi Dayan Return-path: Received: from mail-pl0-f68.google.com ([209.85.160.68]:35919 "EHLO mail-pl0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932546AbeGGRAQ (ORCPT ); Sat, 7 Jul 2018 13:00:16 -0400 Received: by mail-pl0-f68.google.com with SMTP id a7-v6so4209696plp.3 for ; Sat, 07 Jul 2018 10:00:16 -0700 (PDT) In-Reply-To: <1530622472-30156-1-git-send-email-roid@mellanox.com> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, 3 Jul 2018 15:54:32 +0300 Roi Dayan wrote: > Example output is of tos and ttl. > Befoe this fix the format used %x caused output of the pointer > instead of the intended string created in the out variable. > > Fixes: e28b88a464c4 ("tc: jsonify flower filter") > Signed-off-by: Roi Dayan Applied. It would be better to use snprintf to be safe.