From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ido Schimmel Subject: Re: [PATCH v4,net-next] vlan: implement vlan id and protocol changes Date: Sat, 7 Jul 2018 16:14:37 +0300 Message-ID: <20180707131437.GA20505@splinter.mtl.com> References: <20180610231912.1543-1-3chas3@gmail.com> <20180702223528.582-1-3chas3@gmail.com> <20180707.201116.1526423963748651833.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org To: David Miller , 3chas3@gmail.com Return-path: Received: from out1-smtp.messagingengine.com ([66.111.4.25]:39057 "EHLO out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753993AbeGGNOk (ORCPT ); Sat, 7 Jul 2018 09:14:40 -0400 Content-Disposition: inline In-Reply-To: <20180707.201116.1526423963748651833.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-ID: On Sat, Jul 07, 2018 at 08:11:16PM +0900, David Miller wrote: > Chas, it seems to me that you add the new notifier by not even one > driver is listening for the event. > > Either it is necessary, and you should show at least one example > use case, or it not necessary and therefore should not be added. Chas, I'll take a look and send you a patch for mlxsw that you can fold into your v5. In the future, please Cc those who commented on earlier versions of your patch. Thanks!