All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Rob Herring <robh@kernel.org>
Cc: Stefan Popa <stefan.popa@analog.com>,
	Michael.Hennerich@analog.com, lars@metafoo.de, knaack.h@gmx.de,
	pmeerw@pmeerw.net, mark.rutland@arm.com, mchehab@kernel.org,
	davem@davemloft.net, gregkh@linuxfoundation.org,
	akpm@linux-foundation.org, linus.walleij@linaro.org,
	rdunlap@infradead.org, devicetree@vger.kernel.org,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 2/2] dt-bindings: iio: dac: Add docs for AD5758 DAC
Date: Sat, 7 Jul 2018 18:21:02 +0100	[thread overview]
Message-ID: <20180707182102.4ae47234@archlinux> (raw)
In-Reply-To: <20180705211858.GA7441@rob-hp-laptop>

On Thu, 5 Jul 2018 15:18:58 -0600
Rob Herring <robh@kernel.org> wrote:

> On Wed, Jul 04, 2018 at 05:32:53PM +0300, Stefan Popa wrote:
> > Signed-off-by: Stefan Popa <stefan.popa@analog.com>
> > ---
> > Changes in v5:
> > 	- used a dac@0 as a more generic node name instead of ad5758@0.
> > Changes in v4:
> > 	- Nothing changed, just to follow the patch set version.
> > Changes in v3:
> > 	- AD5758 can be both a current and voltage output DAC. The
> > 	  decision is made based on the DT and the channel type is set
> > 	  during probe.
> > 	- range was replaced by range-microvolt and range-microamp
> > 	- dc-dc-mode, range-microvolt and range-microamp are required
> > 	  properties.
> > 	- Introduced a slew-time-us property from which slew rate clock
> > 	  and slew rate step are calculated using a best match algorithm.
> > 	- Added units in the name of the properties.
> > 	- Offered more explanation for the various modes of operation.
> > 
> > Changes in v2:
> > 	- Nothing changed, just to follow the patch set version.
> > 
> >  .../devicetree/bindings/iio/dac/ad5758.txt         | 73 ++++++++++++++++++++++
> >  MAINTAINERS                                        |  1 +
> >  2 files changed, 74 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/iio/dac/ad5758.txt  
> 
> Reviewed-by: Rob Herring <robh@kernel.org> 

There was a bit of white space weirdness in here and some lines that needed
breaking.  I fixed up whilst applying.

Applied to the togreg branch of iio.git and pushed out as testing for the
autobuilders to play with it.

Also feels like I haven't explicitly thanked Rob in a while, so... thanks Rob
for your tireless work on making sure we keep idiocy in device tree bindings
to a minimum!

Jonathan

      reply	other threads:[~2018-07-07 17:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-04 14:32 [PATCH v5 2/2] dt-bindings: iio: dac: Add docs for AD5758 DAC Stefan Popa
2018-07-04 14:32 ` Stefan Popa
2018-07-05 21:18 ` Rob Herring
2018-07-07 17:21   ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180707182102.4ae47234@archlinux \
    --to=jic23@kernel.org \
    --cc=Michael.Hennerich@analog.com \
    --cc=akpm@linux-foundation.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linus.walleij@linaro.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mchehab@kernel.org \
    --cc=pmeerw@pmeerw.net \
    --cc=rdunlap@infradead.org \
    --cc=robh@kernel.org \
    --cc=stefan.popa@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.