From: Jiri Olsa <jolsa@redhat.com>
To: Laura Abbott <labbott@redhat.com>
Cc: Masahiro Yamada <yamada.masahiro@socionext.com>,
Josh Poimboeuf <jpoimboe@redhat.com>,
Jiri Olsa <jolsa@kernel.org>,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
Robin Jarry <robin.jarry@6wind.com>
Subject: Re: [PATCH 2/7] tools: build: Use HOSTLDFLAGS with fixdep
Date: Sun, 8 Jul 2018 12:55:15 +0200 [thread overview]
Message-ID: <20180708105515.GA29861@krava> (raw)
In-Reply-To: <20180707010709.16648-3-labbott@redhat.com>
On Fri, Jul 06, 2018 at 06:07:04PM -0700, Laura Abbott wrote:
> The final link of fixdep uses LDFLAGS but not the existing HOSTLDFLAGS.
> Fix this.
>
> Signed-off-by: Laura Abbott <labbott@redhat.com>
> ---
> This was another one where I couldn't tell of the use of LDFLAGS was a
> typo or intentional, hence keeping both.
I think the replacement (using just HOSTLDFLAGS) should
be the correct fix, moreover fixdep doesn't have any special
link requirements
thanks,
jirka
> ---
> tools/build/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/build/Makefile b/tools/build/Makefile
> index 5eb4b5ad79cb..cd0fd2cd165b 100644
> --- a/tools/build/Makefile
> +++ b/tools/build/Makefile
> @@ -43,7 +43,7 @@ $(OUTPUT)fixdep-in.o: FORCE
> $(Q)$(MAKE) $(build)=fixdep
>
> $(OUTPUT)fixdep: $(OUTPUT)fixdep-in.o
> - $(QUIET_LINK)$(HOSTCC) $(LDFLAGS) -o $@ $<
> + $(QUIET_LINK)$(HOSTCC) $(HOSTLDFLAGS) $(LDFLAGS) -o $@ $<
>
> FORCE:
>
> --
> 2.17.1
>
next prev parent reply other threads:[~2018-07-08 10:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-07 1:07 [PATCH 0/7] HOSTFLAGS and HOSTLDFLAGS from the environment (new approach) Laura Abbott
2018-07-07 1:07 ` [PATCH 1/7] tools: build: Fixup host c flags Laura Abbott
2018-07-08 10:59 ` Jiri Olsa
2018-07-07 1:07 ` [PATCH 2/7] tools: build: Use HOSTLDFLAGS with fixdep Laura Abbott
2018-07-08 10:55 ` Jiri Olsa [this message]
2018-07-07 1:07 ` [PATCH 3/7] treewide: Rename HOSTCFLAGS -> KBUILD_HOSTCFLAGS Laura Abbott
2018-07-08 2:30 ` Masahiro Yamada
2018-07-07 1:07 ` [PATCH 4/7] treewide: Rename HOSTCXXFLAGS to KBUILD_HOSTCXXFLAGS Laura Abbott
2018-07-08 2:30 ` Masahiro Yamada
2018-07-07 1:07 ` [PATCH 5/7] treewide: Rename HOSTLDFLAGS to KBUILD_HOSTLDFLAGS Laura Abbott
2018-07-07 1:07 ` [PATCH 6/7] treewide: Rename HOST_LOADLIBES to KBUILD_HOSTLDLIBS Laura Abbott
2018-07-08 2:31 ` Masahiro Yamada
2018-07-07 1:07 ` [PATCH 7/7] Kbuild: Use HOST*FLAGS options from the command line Laura Abbott
2018-07-08 2:31 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180708105515.GA29861@krava \
--to=jolsa@redhat.com \
--cc=jolsa@kernel.org \
--cc=jpoimboe@redhat.com \
--cc=labbott@redhat.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robin.jarry@6wind.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.