All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chao Yu <chao@kernel.org>
To: jaegeuk@kernel.org
Cc: linux-f2fs-devel@lists.sourceforge.net,
	linux-kernel@vger.kernel.org, Chao Yu <yuchao0@huawei.com>
Subject: [PATCH 1/5] f2fs: detect bug_on in f2fs_wait_discard_bios
Date: Sun,  8 Jul 2018 22:16:53 +0800	[thread overview]
Message-ID: <20180708141657.24641-1-chao@kernel.org> (raw)

From: Chao Yu <yuchao0@huawei.com>

Add bug_on to detect potential non-empty discard wait list.

Signed-off-by: Chao Yu <yuchao0@huawei.com>
---
 fs/f2fs/segment.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
index cbf8f3f9a8e7..e55188975fcc 100644
--- a/fs/f2fs/segment.c
+++ b/fs/f2fs/segment.c
@@ -1495,6 +1495,8 @@ bool f2fs_wait_discard_bios(struct f2fs_sb_info *sbi)
 
 	/* just to make sure there is no pending discard commands */
 	__wait_all_discard_cmd(sbi, NULL);
+
+	f2fs_bug_on(sbi, atomic_read(&dcc->discard_cmd_cnt));
 	return dropped;
 }
 
-- 
2.16.2.17.g38e79b1fd

             reply	other threads:[~2018-07-08 14:16 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-08 14:16 Chao Yu [this message]
2018-07-08 14:16 ` [PATCH 2/5] f2fs: clean up with IS_INODE() Chao Yu
2018-07-08 14:16 ` [PATCH 3/5] f2fs: fix to do sanity check with i_extra_isize Chao Yu
2018-07-08 14:16   ` Chao Yu
2018-07-08 14:16 ` [PATCH 4/5] f2fs: fix to do sanity check with cp_pack_start_sum Chao Yu
2018-07-08 14:16   ` Chao Yu
2018-07-08 14:16 ` [PATCH 5/5] f2fs: fix to propagate error from __get_meta_page() Chao Yu
2018-07-08 14:16   ` Chao Yu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180708141657.24641-1-chao@kernel.org \
    --to=chao@kernel.org \
    --cc=jaegeuk@kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=yuchao0@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.