All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: boris.brezillon@bootlin.com,
	Fabio Estevam <fabio.estevam@nxp.com>, Han Xu <han.xu@nxp.com>,
	linux-mtd@lists.infradead.org
Subject: Re: [PATCH] mtd: rawnand: gpmi: Switch to SPDX identifier
Date: Mon, 9 Jul 2018 00:00:34 +0200	[thread overview]
Message-ID: <20180709000034.5d0920c5@xps13> (raw)
In-Reply-To: <CAOMZO5CU7EkPOsaneMm5cBsUvHD8diW8MLb+aD-Jaw-_G9AbYA@mail.gmail.com>

Hi Fabio,

Fabio Estevam <festevam@gmail.com> wrote on Sat, 7 Jul 2018 14:16:48
-0300:

> Hi Miquel,
> 
> On Sat, Jul 7, 2018 at 2:00 PM, Miquel Raynal <miquel.raynal@bootlin.com> wrote:
> 
> >> +// SPDX-License-Identifier: GPL-2.0+
> >> +//
> >> +// Freescale GPMI NAND Flash Driver
> >> +//
> >> +// Copyright (C) 2008-2011 Freescale Semiconductor, Inc.
> >> +// Copyright (C) 2008 Embedded Alley Solutions, Inc.  
> >
> > Maybe I'm not aware of something recent but I thought only the SPDX
> > license tag was supposed to use '//' comments while the other lines
> > should be still using '/* */' like any other comments in the code?  
> 
> There are some subsystem maintainers (and also Linus) that prefer
> putting everything in // style:
> https://lkml.org/lkml/2017/11/25/133

Thanks for the thread!

Well then, next time, just choose your favourite one.

v2 (with the two patches) applied to nand/next.

Thanks,
Miquèl

      reply	other threads:[~2018-07-08 22:00 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-06 17:28 [PATCH] mtd: rawnand: gpmi: Switch to SPDX identifier Fabio Estevam
2018-07-07 17:00 ` Miquel Raynal
2018-07-07 17:16   ` Fabio Estevam
2018-07-08 22:00     ` Miquel Raynal [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180709000034.5d0920c5@xps13 \
    --to=miquel.raynal@bootlin.com \
    --cc=boris.brezillon@bootlin.com \
    --cc=fabio.estevam@nxp.com \
    --cc=festevam@gmail.com \
    --cc=han.xu@nxp.com \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.