From: Jaya Durga <rjdurga@gmail.com>
To: gregkh@linuxfoundation.org
Cc: quytelda@tamalin.org, jonathankim@gctsemi.com,
deanahn@gctsemi.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH] Staging: gdm724x: gdm_tty.c:Fixed Macro argument reuse
Date: Mon, 9 Jul 2018 15:30:20 +0530 [thread overview]
Message-ID: <20180709100020.7399-1-rjdurga@gmail.com> (raw)
From: root <root@boss.chennai.cdac.in>
CHECK: Macro argument reuse 'gdm' - possible side-effects?
convert GDM_TTY_READY to gdm_tty_ready static function
to fix checkpath check
Signed-off-by: Jaya Durga <rjdurga@gmail.com>
---
drivers/staging/gdm724x/gdm_tty.c | 14 +++++++++-----
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/gdm724x/gdm_tty.c b/drivers/staging/gdm724x/gdm_tty.c
index bf554f7c56ca..5de1940c1f79 100644
--- a/drivers/staging/gdm724x/gdm_tty.c
+++ b/drivers/staging/gdm724x/gdm_tty.c
@@ -27,7 +27,11 @@
#define MUX_TX_MAX_SIZE 2048
-#define GDM_TTY_READY(gdm) (gdm && gdm->tty_dev && gdm->port.count)
+static unsigned int gdm_tty_ready(struct gdm *gdm)
+{
+return (gdm && gdm->tty_dev && gdm->port.count);
+}
+
static struct tty_driver *gdm_driver[TTY_MAX_COUNT];
static struct gdm *gdm_table[TTY_MAX_COUNT][GDM_TTY_MINOR];
@@ -127,7 +131,7 @@ static int gdm_tty_recv_complete(void *data,
{
struct gdm *gdm = tty_dev->gdm[index];
- if (!GDM_TTY_READY(gdm)) {
+ if (!gdm_tty_ready(gdm)) {
if (complete == RECV_PACKET_PROCESS_COMPLETE)
gdm->tty_dev->recv_func(gdm->tty_dev->priv_dev,
gdm_tty_recv_complete);
@@ -154,7 +158,7 @@ static void gdm_tty_send_complete(void *arg)
{
struct gdm *gdm = arg;
- if (!GDM_TTY_READY(gdm))
+ if (!gdm_tty_ready(gdm))
return;
tty_port_tty_wakeup(&gdm->port);
@@ -168,7 +172,7 @@ static int gdm_tty_write(struct tty_struct *tty, const unsigned char *buf,
int sent_len = 0;
int sending_len = 0;
- if (!GDM_TTY_READY(gdm))
+ if (!gdm_tty_ready(gdm))
return -ENODEV;
if (!len)
@@ -195,7 +199,7 @@ static int gdm_tty_write_room(struct tty_struct *tty)
{
struct gdm *gdm = tty->driver_data;
- if (!GDM_TTY_READY(gdm))
+ if (!gdm_tty_ready(gdm))
return -ENODEV;
return WRITE_SIZE;
next reply other threads:[~2018-07-09 10:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-09 10:00 Jaya Durga [this message]
2018-07-09 10:34 ` [PATCH] Staging: gdm724x: gdm_tty.c:Fixed Macro argument reuse Dan Carpenter
-- strict thread matches above, loose matches on Subject: below --
2018-07-09 12:36 Jaya Durga
2018-07-09 12:56 ` Dan Carpenter
2018-07-09 13:02 ` Jaya Durga
2018-07-09 10:57 Jaya Durga
2018-07-09 11:43 ` Dan Carpenter
2018-07-09 11:57 ` Greg KH
2018-07-09 8:44 Jaya Durga
2018-07-09 9:18 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180709100020.7399-1-rjdurga@gmail.com \
--to=rjdurga@gmail.com \
--cc=deanahn@gctsemi.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jonathankim@gctsemi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=quytelda@tamalin.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.