From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Ricardo Leitner Subject: Re: [PATCH] net: sched: Fix warnings from xchg() on RCU'd cookie pointer. Date: Mon, 9 Jul 2018 12:30:12 -0300 Message-ID: <20180709153012.GA8880@localhost.localdomain> References: <20180708.170358.1177815849312901978.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, vladbu@mellanox.com, jiri@mellanox.com To: David Miller Return-path: Received: from mail-qk0-f194.google.com ([209.85.220.194]:43672 "EHLO mail-qk0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933248AbeGIPaQ (ORCPT ); Mon, 9 Jul 2018 11:30:16 -0400 Received: by mail-qk0-f194.google.com with SMTP id z74-v6so9888411qkb.10 for ; Mon, 09 Jul 2018 08:30:16 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20180708.170358.1177815849312901978.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-ID: On Sun, Jul 08, 2018 at 05:03:58PM +0900, David Miller wrote: > > The kbuild test robot reports: > > >> net/sched/act_api.c:71:15: sparse: incorrect type in initializer (different address spaces) @@ expected struct tc_cookie [noderef] *__ret @@ got [noderef] *__ret @@ > net/sched/act_api.c:71:15: expected struct tc_cookie [noderef] *__ret > net/sched/act_api.c:71:15: got struct tc_cookie *new_cookie > >> net/sched/act_api.c:71:13: sparse: incorrect type in assignment (different address spaces) @@ expected struct tc_cookie *old @@ got struct tc_cookie [noderef] net/sched/act_api.c:71:13: expected struct tc_cookie *old > net/sched/act_api.c:71:13: got struct tc_cookie [noderef] *[assigned] __ret This one: > >> net/sched/act_api.c:132:48: sparse: dereference of noderef expression Actually belongs to a different issue, that was reported in the same email, but which wasn't handled in this patch. Marcelo