From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Zijlstra Subject: Re: [RFC PATCH v4 09/12] sched/fair: Introduce an energy estimation helper function Date: Mon, 9 Jul 2018 17:42:26 +0200 Message-ID: <20180709154226.GZ2476@hirez.programming.kicks-ass.net> References: <20180628114043.24724-1-quentin.perret@arm.com> <20180628114043.24724-10-quentin.perret@arm.com> <20180706131243.GV2458@hirez.programming.kicks-ass.net> <20180706151212.GD17577@e108498-lin.cambridge.arm.com> <20180706154949.GO2494@hirez.programming.kicks-ass.net> <20180706170443.GE17577@e108498-lin.cambridge.arm.com> <20180709120138.GQ2494@hirez.programming.kicks-ass.net> <20180709152825.GA17598@e108498-lin.cambridge.arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20180709152825.GA17598@e108498-lin.cambridge.arm.com> Sender: linux-kernel-owner@vger.kernel.org To: Quentin Perret Cc: rjw@rjwysocki.net, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, gregkh@linuxfoundation.org, mingo@redhat.com, dietmar.eggemann@arm.com, morten.rasmussen@arm.com, chris.redpath@arm.com, patrick.bellasi@arm.com, valentin.schneider@arm.com, vincent.guittot@linaro.org, thara.gopinath@linaro.org, viresh.kumar@linaro.org, tkjos@google.com, joel@joelfernandes.org, smuckle@google.com, adharmap@quicinc.com, skannan@quicinc.com, pkondeti@codeaurora.org, juri.lelli@redhat.com, edubezval@gmail.com, srinivas.pandruvada@linux.intel.com, currojerez@riseup.net, javi.merino@kernel.org List-Id: linux-pm@vger.kernel.org On Mon, Jul 09, 2018 at 04:28:26PM +0100, Quentin Perret wrote: > What about moving schedutil_freq_util() to sched.h and give it a more > generic name (total_cpu_util() ?) with no dependencies on > CONFIG_CPU_FREQ_GOV_SCHEDUTIL ? Also, 'energy_util' would have to be > renamed I guess (busy_time_util ?). Bit big for an inline, and I don't think there's much point using all this without schedutil. You already rely on it anyhow.