From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Ricardo Leitner Subject: Re: [PATCH v3 net-next] net/sched: add skbprio scheduler Date: Mon, 9 Jul 2018 12:44:09 -0300 Message-ID: <20180709154409.GC8880@localhost.localdomain> References: <20180707101351.GA8300@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: xiyou.wangcong@gmail.com, jhs@mojatatu.com, jiri@resnulli.us, davem@davemloft.net, netdev@vger.kernel.org, doucette@bu.edu, michel@digirati.com.br To: Nishanth Devarajan Return-path: Received: from mail-qt0-f196.google.com ([209.85.216.196]:36625 "EHLO mail-qt0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932789AbeGIPoM (ORCPT ); Mon, 9 Jul 2018 11:44:12 -0400 Received: by mail-qt0-f196.google.com with SMTP id f1-v6so15741308qti.3 for ; Mon, 09 Jul 2018 08:44:12 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20180707101351.GA8300@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: On Sat, Jul 07, 2018 at 03:43:55PM +0530, Nishanth Devarajan wrote: > net/sched: add skbprio scheduer > > Skbprio (SKB Priority Queue) is a queueing discipline that prioritizes packets > according to their skb->priority field. Under congestion, already-enqueued lower > priority packets will be dropped to make space available for higher priority > packets. Skbprio was conceived as a solution for denial-of-service defenses that > need to route packets with different priorities as a means to overcome DoS > attacks. Why can't we implement this as a new flag for sch_prio.c? I don't see why this duplication is needed, especially because it will only be "slower" (as in, it will do more work) when qdisc is already full and dropping packets anyway. Marcelo