From: Jonathan Tan <jonathantanmy@google.com>
To: gitster@pobox.com
Cc: jonathantanmy@google.com, git@vger.kernel.org, git@jeffhostetler.com
Subject: Re: [PATCH 0/2] Avoiding errors when partial cloning a tagged blob
Date: Mon, 9 Jul 2018 13:07:49 -0700 [thread overview]
Message-ID: <20180709200749.190861-1-jonathantanmy@google.com> (raw)
In-Reply-To: <xmqqy3ekcihe.fsf@gitster-ct.c.googlers.com>
> > An argument could be made that we should not merge patch 2 just yet due
> > to the fact that some server implementations (such as Git and JGit)
> > still exhibit the old behavior, and the resulting clones (albeit failing
> > fsck) are still usable, because when attempting to load the blob, Git
> > will automatically fetch it. I'm on the fence about this, and have
> > included patch 2 in this patch set nevertheless for completeness.
>
> I think the latter is probably a good thing to nudge the server
> implementations in the right direction by gently poking them ;-)
OK, I'll keep patch 2 then.
> The patches textually apply cleanly on 'master' but apparently it
> needs some fixes in jt/partial-clone-fsck-connectivity topic to
> function correctly?
I forgot to mention in the original e-mail that this is on
bw/ref-in-want. (I mentioned it in an e-mail I sent later [1].) I've
checked and basing it on both bw/ref-in-want and
jt/partial-clone-fsck-connectivity (which is based on bw/ref-in-want
itself) both work, so you can choose either one.
[1] https://public-inbox.org/git/20180706193847.160161-1-jonathantanmy@google.com/
prev parent reply other threads:[~2018-07-09 20:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-06 19:34 [PATCH 0/2] Avoiding errors when partial cloning a tagged blob Jonathan Tan
2018-07-06 19:34 ` [PATCH 1/2] upload-pack: send refs' objects despite "filter" Jonathan Tan
2018-07-06 19:34 ` [PATCH 2/2] clone: check connectivity even if clone is partial Jonathan Tan
2018-07-06 19:38 ` [PATCH 0/2] Avoiding errors when partial cloning a tagged blob Jonathan Tan
2018-07-06 20:10 ` Junio C Hamano
2018-07-06 21:25 ` Jonathan Tan
2018-07-06 21:29 ` Jonathan Nieder
2018-07-06 22:18 ` Junio C Hamano
2018-07-09 16:07 ` Junio C Hamano
2018-07-09 17:10 ` Jonathan Tan
2018-07-09 19:33 ` Junio C Hamano
2018-07-09 20:07 ` Jonathan Tan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180709200749.190861-1-jonathantanmy@google.com \
--to=jonathantanmy@google.com \
--cc=git@jeffhostetler.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.