From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Date: Tue, 10 Jul 2018 05:24:36 +0000 Subject: Re: [PATCH] backlight: adp8860: Mark expected switch fall-through Message-Id: <20180710052436.GB4641@dell> List-Id: References: <20180709215156.GA8782@embeddedor.com> In-Reply-To: <20180709215156.GA8782@embeddedor.com> MIME-Version: 1.0 Content-Type: text/plain; charset="windows-1254" Content-Transfer-Encoding: base64 To: "Gustavo A. R. Silva" Cc: Daniel Thompson , Michael Hennerich , Bartlomiej Zolnierkiewicz , Jingoo Han , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org T24gTW9uLCAwOSBKdWwgMjAxOCwgR3VzdGF2byBBLiBSLiBTaWx2YSB3cm90ZToKCj4gSW4gcHJl cGFyYXRpb24gdG8gZW5hYmxpbmcgLVdpbXBsaWNpdC1mYWxsdGhyb3VnaCwgbWFyayBzd2l0Y2gg Y2FzZXMKPiB3aGVyZSB3ZSBhcmUgZXhwZWN0aW5nIHRvIGZhbGwgdGhyb3VnaC4KPiAKPiBTaWdu ZWQtb2ZmLWJ5OiBHdXN0YXZvIEEuIFIuIFNpbHZhIDxndXN0YXZvQGVtYmVkZGVkb3IuY29tPgo+ IC0tLQo+ICBkcml2ZXJzL3ZpZGVvL2JhY2tsaWdodC9hZHA4ODYwX2JsLmMgfCAxICsKPiAgMSBm aWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspCgpMb29rcyBnb29kIHRvIG1lLCBidXQgRGFuIHNo b3VsZCBzdGlsbCByZXZpZXcuCgogIGh0dHBzOi8vZ2NjLmdudS5vcmcvb25saW5lZG9jcy9nY2Mt OC4xLjAvZ2NjLnBkZiNwYWdlhgoKQWNrZWQtYnk6IExlZSBKb25lcyA8bGVlLmpvbmVzQGxpbmFy by5vcmc+CgotLSAKTGVlIEpvbmVzIFvmnY7nkLzmlq9dCkxpbmFybyBTZXJ2aWNlcyBUZWNobmlj YWwgTGVhZApMaW5hcm8ub3JnIOKUgiBPcGVuIHNvdXJjZSBzb2Z0d2FyZSBmb3IgQVJNIFNvQ3MK Rm9sbG93IExpbmFybzogRmFjZWJvb2sgfCBUd2l0dGVyIHwgQmxvZwotLQpUbyB1bnN1YnNjcmli ZSBmcm9tIHRoaXMgbGlzdDogc2VuZCB0aGUgbGluZSAidW5zdWJzY3JpYmUgbGludXgtZmJkZXYi IGluCnRoZSBib2R5IG9mIGEgbWVzc2FnZSB0byBtYWpvcmRvbW9Admdlci5rZXJuZWwub3JnCk1v cmUgbWFqb3Jkb21vIGluZm8gYXQgIGh0dHA6Ly92Z2VyLmtlcm5lbC5vcmcvbWFqb3Jkb21vLWlu Zm8uaHRtbA== From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH] backlight: adp8860: Mark expected switch fall-through Date: Tue, 10 Jul 2018 06:24:36 +0100 Message-ID: <20180710052436.GB4641@dell> References: <20180709215156.GA8782@embeddedor.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by gabe.freedesktop.org (Postfix) with ESMTPS id E2A756E01C for ; Tue, 10 Jul 2018 05:24:39 +0000 (UTC) Received: by mail-wr1-x441.google.com with SMTP id h10-v6so13120831wre.6 for ; Mon, 09 Jul 2018 22:24:39 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20180709215156.GA8782@embeddedor.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: "Gustavo A. R. Silva" Cc: Daniel Thompson , Michael Hennerich , Bartlomiej Zolnierkiewicz , Jingoo Han , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org T24gTW9uLCAwOSBKdWwgMjAxOCwgR3VzdGF2byBBLiBSLiBTaWx2YSB3cm90ZToKCj4gSW4gcHJl cGFyYXRpb24gdG8gZW5hYmxpbmcgLVdpbXBsaWNpdC1mYWxsdGhyb3VnaCwgbWFyayBzd2l0Y2gg Y2FzZXMKPiB3aGVyZSB3ZSBhcmUgZXhwZWN0aW5nIHRvIGZhbGwgdGhyb3VnaC4KPiAKPiBTaWdu ZWQtb2ZmLWJ5OiBHdXN0YXZvIEEuIFIuIFNpbHZhIDxndXN0YXZvQGVtYmVkZGVkb3IuY29tPgo+ IC0tLQo+ICBkcml2ZXJzL3ZpZGVvL2JhY2tsaWdodC9hZHA4ODYwX2JsLmMgfCAxICsKPiAgMSBm aWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspCgpMb29rcyBnb29kIHRvIG1lLCBidXQgRGFuIHNo b3VsZCBzdGlsbCByZXZpZXcuCgogIGh0dHBzOi8vZ2NjLmdudS5vcmcvb25saW5lZG9jcy9nY2Mt OC4xLjAvZ2NjLnBkZiNwYWdlPTg2CgpBY2tlZC1ieTogTGVlIEpvbmVzIDxsZWUuam9uZXNAbGlu YXJvLm9yZz4KCi0tIApMZWUgSm9uZXMgW+adjueQvOaWr10KTGluYXJvIFNlcnZpY2VzIFRlY2hu aWNhbCBMZWFkCkxpbmFyby5vcmcg4pSCIE9wZW4gc291cmNlIHNvZnR3YXJlIGZvciBBUk0gU29D cwpGb2xsb3cgTGluYXJvOiBGYWNlYm9vayB8IFR3aXR0ZXIgfCBCbG9nCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QK ZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9w Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 059E0C3279B for ; Tue, 10 Jul 2018 05:24:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AB6FC2089B for ; Tue, 10 Jul 2018 05:24:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linaro.org header.i=@linaro.org header.b="Z7v8OXrl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AB6FC2089B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751015AbeGJFYm (ORCPT ); Tue, 10 Jul 2018 01:24:42 -0400 Received: from mail-wr1-f65.google.com ([209.85.221.65]:38631 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750913AbeGJFYj (ORCPT ); Tue, 10 Jul 2018 01:24:39 -0400 Received: by mail-wr1-f65.google.com with SMTP id m1-v6so405639wrg.5 for ; Mon, 09 Jul 2018 22:24:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=1MeiGYxmIz+IkmutBMq62FwvrWPg0aSu9Ral76dvaJM=; b=Z7v8OXrl3Zkmz660bLlCcUUdoTeFbih5TorkqkykQHjaX9gqCst8Lu40499iun4Ai1 bhi9gtykaduRTcqF+6kFx/pXsg5IaUkDZnALaOZfE8XVoBH8R7tY2J8BBocyJM5FPUD3 EhSd3ibOVAxQbzpSLx9KrR9CxQtQ07msviSWY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=1MeiGYxmIz+IkmutBMq62FwvrWPg0aSu9Ral76dvaJM=; b=TjTVo5lVDUuFjXZWj+6AvdcgQLiCBpXjl8Hvg531gHxMkaFiaSFQKhw0d8QjLywQ/j ihM5CGw6URIhvi3AXme6tSFeQrIeJJMAukSOLdlggGAeUfw1vg2ombDCjVXkpNpll1XB MEAYgHvnKwjTszlXepSVUqgsteZM56qCPkA7lYCJo5qAterR6u+tfqjOUsuS/VEOOal4 Wg+VxYNIcI6HHp8Ag3ei/MbDu9a1N1qcghJ0mpSkd6L053VW1WNRYYr8jEzUmhPJlN2o n2uS13fcynTsQKa3F9iuiMc2iCUX/eHMoSOBQhQEPX7CpFpeYrQl+iQuluOXJbnHHl04 Xmeg== X-Gm-Message-State: AOUpUlFsnUpbvX0qevTaXk3p3B7q4uEjlH4PFsanN+TFG8WxhxfFd/Gr U12M8DuuZdmW7JnBJ+JA7iSTOolo3To= X-Google-Smtp-Source: AAOMgpfUJAHZ/MCS8j7ypQ1WkOfzt2KUuv2HXyINOqzv9AsPRvTTlaes5CUdruOuuuCwD71CAooDMg== X-Received: by 2002:adf:98d2:: with SMTP id w76-v6mr5389310wrb.124.1531200278563; Mon, 09 Jul 2018 22:24:38 -0700 (PDT) Received: from dell ([2.27.167.87]) by smtp.gmail.com with ESMTPSA id s13-v6sm17362381wra.22.2018.07.09.22.24.37 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 09 Jul 2018 22:24:37 -0700 (PDT) Date: Tue, 10 Jul 2018 06:24:36 +0100 From: Lee Jones To: "Gustavo A. R. Silva" Cc: Michael Hennerich , Daniel Thompson , Jingoo Han , Bartlomiej Zolnierkiewicz , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] backlight: adp8860: Mark expected switch fall-through Message-ID: <20180710052436.GB4641@dell> References: <20180709215156.GA8782@embeddedor.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180709215156.GA8782@embeddedor.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 09 Jul 2018, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Signed-off-by: Gustavo A. R. Silva > --- > drivers/video/backlight/adp8860_bl.c | 1 + > 1 file changed, 1 insertion(+) Looks good to me, but Dan should still review. https://gcc.gnu.org/onlinedocs/gcc-8.1.0/gcc.pdf#page=86 Acked-by: Lee Jones -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog