All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: qemu-block@nongnu.org
Cc: mreitz@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 0/2] block: Fix attaching drained child node
Date: Tue, 10 Jul 2018 10:37:41 +0200	[thread overview]
Message-ID: <20180710083741.GA5852@localhost.localdomain> (raw)
In-Reply-To: <20180703175049.27669-1-kwolf@redhat.com>

Am 03.07.2018 um 19:50 hat Kevin Wolf geschrieben:
> This fixes the following case that was reported by Max and was caused by
> not correctly waiting for activity to cease on the parent node before
> attaching a drained child node:
> 
> $ ./qemu-img create -f qed foo.qed 64M
> Formatting 'foo.qed', fmt=qed size=67108864 cluster_size=65536
> $ echo "{'execute':'qmp_capabilities'}
>         {'execute':'blockdev-snapshot',
>          'arguments':{'node':'backing','overlay':'overlay'}}
>         {'execute':'quit'}" | \
>     x86_64-softmmu/qemu-system-x86_64 -qmp stdio -nodefaults \
>         -blockdev "{'node-name':'backing','driver':'null-co'}" \
>         -blockdev "{'node-name':'overlay','driver':'qed',
>                     'file':{'driver':'file','filename':'foo.qed'}}"
> {"QMP": {"version": {"qemu": {"micro": 50, "minor": 12, "major": 2},
> "package": "v2.12.0-1422-g0109e7e6f8"}, "capabilities": []}}
> {"return": {}}
> qemu-system-x86_64: block.c:3434: bdrv_replace_node: Assertion
> `!atomic_read(&to->in_flight)' failed.
> [1]    5252 done                 echo  |
>        5253 abort (core dumped)  x86_64-softmmu/qemu-system-x86_64 -qmp
> stdio -nodefaults -blockdev  -blockdev

Applied to the block branch.

Kevin

      parent reply	other threads:[~2018-07-10  8:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-03 17:50 [Qemu-devel] [PATCH 0/2] block: Fix attaching drained child node Kevin Wolf
2018-07-03 17:50 ` [Qemu-devel] [PATCH 1/2] block: Poll after drain on attaching a node Kevin Wolf
2018-07-03 17:50 ` [Qemu-devel] [PATCH 2/2] test-bdrv-drain: Test bdrv_append() to drained node Kevin Wolf
2018-07-10  8:37 ` Kevin Wolf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180710083741.GA5852@localhost.localdomain \
    --to=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.