From: Peter Xu <peterx@redhat.com>
To: qemu-devel@nongnu.org
Cc: peterx@redhat.com, Juan Quintela <quintela@redhat.com>,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
Balamuruhan S <bala24@linux.vnet.ibm.com>
Subject: [Qemu-devel] [PATCH for-3.0 v2 08/10] tests: introduce wait_for_migration_status()
Date: Tue, 10 Jul 2018 17:19:00 +0800 [thread overview]
Message-ID: <20180710091902.28780-9-peterx@redhat.com> (raw)
In-Reply-To: <20180710091902.28780-1-peterx@redhat.com>
It's generalized from wait_for_migration_complete() to allow us to wait
for any migration status besides failure.
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Reviewed-by: Balamuruhan S <bala24@linux.vnet.ibm.com>
Signed-off-by: Peter Xu <peterx@redhat.com>
---
tests/migration-test.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/tests/migration-test.c b/tests/migration-test.c
index 1d85ccbef1..761bf62ffe 100644
--- a/tests/migration-test.c
+++ b/tests/migration-test.c
@@ -231,14 +231,15 @@ static void read_blocktime(QTestState *who)
qobject_unref(rsp_return);
}
-static void wait_for_migration_complete(QTestState *who)
+static void wait_for_migration_status(QTestState *who,
+ const char *goal)
{
while (true) {
bool completed;
char *status;
status = migrate_query_status(who);
- completed = strcmp(status, "completed") == 0;
+ completed = strcmp(status, goal) == 0;
g_assert_cmpstr(status, !=, "failed");
g_free(status);
if (completed) {
@@ -248,6 +249,11 @@ static void wait_for_migration_complete(QTestState *who)
}
}
+static void wait_for_migration_complete(QTestState *who)
+{
+ wait_for_migration_status(who, "completed");
+}
+
static void wait_for_migration_pass(QTestState *who)
{
uint64_t initial_pass = get_migration_pass(who);
--
2.17.1
next prev parent reply other threads:[~2018-07-10 9:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-10 9:18 [Qemu-devel] [PATCH for-3.0 v2 00/10] migration: postcopy recovery unit test, bug fixes Peter Xu
2018-07-10 9:18 ` [Qemu-devel] [PATCH for-3.0 v2 01/10] migration: simplify check to use qemu file buffer Peter Xu
2018-07-10 9:18 ` [Qemu-devel] [PATCH for-3.0 v2 02/10] migration: loosen recovery check when load vm Peter Xu
2018-07-10 9:18 ` [Qemu-devel] [PATCH for-3.0 v2 03/10] migration: fix incorrect bitmap size calculation Peter Xu
2018-07-10 9:18 ` [Qemu-devel] [PATCH for-3.0 v2 04/10] migration: show pause/recover state on dst host Peter Xu
2018-07-10 11:20 ` Dr. David Alan Gilbert
2018-07-10 9:18 ` [Qemu-devel] [PATCH for-3.0 v2 05/10] tests: introduce migrate_postcopy_* helpers Peter Xu
2018-07-10 9:18 ` [Qemu-devel] [PATCH for-3.0 v2 06/10] tests: allow migrate() to take extra flags Peter Xu
2018-07-10 9:18 ` [Qemu-devel] [PATCH for-3.0 v2 07/10] tests: introduce migrate_query*() helpers Peter Xu
2018-07-10 9:19 ` Peter Xu [this message]
2018-07-10 9:19 ` [Qemu-devel] [PATCH for-3.0 v2 09/10] tests: add postcopy recovery test Peter Xu
2018-07-10 11:25 ` Dr. David Alan Gilbert
2018-07-10 12:23 ` Juan Quintela
2018-07-10 9:19 ` [Qemu-devel] [PATCH for-3.0 v2 10/10] tests: hide stderr for " Peter Xu
2018-07-10 12:18 ` [Qemu-devel] [PATCH for-3.0 v2 00/10] migration: postcopy recovery unit test, bug fixes Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180710091902.28780-9-peterx@redhat.com \
--to=peterx@redhat.com \
--cc=bala24@linux.vnet.ibm.com \
--cc=dgilbert@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.