From mboxrd@z Thu Jan 1 00:00:00 1970 From: will.deacon@arm.com (Will Deacon) Date: Tue, 10 Jul 2018 10:36:16 +0100 Subject: [PATCH] Revert "arm64: Use aarch64elf and aarch64elfb emulation mode variants" In-Reply-To: References: <20180709200956.31158-1-labbott@redhat.com> <20180710090125.GA28924@arm.com> Message-ID: <20180710093615.GA30095@arm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Jul 10, 2018 at 11:30:39AM +0200, Paul Kocialkowski wrote: > On Tue, 2018-07-10 at 10:01 +0100, Will Deacon wrote: > > Thanks, Laura. > > > > I'll take this as a fix, and add a comment to the Makefile to justify > > why we need the linux target. > > So this comes down to either breaking fedora/debian toolchains (that > don't support elf emulation mode) or breaking bare-metal toolchains > (that don't support linux emulation mode). > > Since Linux is a bare-metal project that does not technically require > the linux target (who said using "Linux" for all things is confusing?), > I think it should aim for the elf target in the long term. > > But well, breaking Linux build in common distros isn't good either, so I > guess it makes sense to revert this while distros toolchains are being > fixed. Hopefully, it won't take too long. > > What do you think? Yes, we need to revert the change since it's a regression otherwise. I think the best course of action here would be to find a way that we can either tell the linker that it doesn't need the missing linker scripts because we're providing our own, or find a way to pass different LD flags depending on whether or not we have a linux toolchain. For now, I've pushed the revert to for-next/fixes. Will From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F927C3279B for ; Tue, 10 Jul 2018 09:35:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DE966208E2 for ; Tue, 10 Jul 2018 09:35:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DE966208E2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933245AbeGJJfg (ORCPT ); Tue, 10 Jul 2018 05:35:36 -0400 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:43616 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751335AbeGJJff (ORCPT ); Tue, 10 Jul 2018 05:35:35 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A7E827A9; Tue, 10 Jul 2018 02:35:34 -0700 (PDT) Received: from edgewater-inn.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 78E613F318; Tue, 10 Jul 2018 02:35:34 -0700 (PDT) Received: by edgewater-inn.cambridge.arm.com (Postfix, from userid 1000) id 325DE1AE53F1; Tue, 10 Jul 2018 10:36:16 +0100 (BST) Date: Tue, 10 Jul 2018 10:36:16 +0100 From: Will Deacon To: Paul Kocialkowski Cc: Laura Abbott , Catalin Marinas , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Revert "arm64: Use aarch64elf and aarch64elfb emulation mode variants" Message-ID: <20180710093615.GA30095@arm.com> References: <20180709200956.31158-1-labbott@redhat.com> <20180710090125.GA28924@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 10, 2018 at 11:30:39AM +0200, Paul Kocialkowski wrote: > On Tue, 2018-07-10 at 10:01 +0100, Will Deacon wrote: > > Thanks, Laura. > > > > I'll take this as a fix, and add a comment to the Makefile to justify > > why we need the linux target. > > So this comes down to either breaking fedora/debian toolchains (that > don't support elf emulation mode) or breaking bare-metal toolchains > (that don't support linux emulation mode). > > Since Linux is a bare-metal project that does not technically require > the linux target (who said using "Linux" for all things is confusing?), > I think it should aim for the elf target in the long term. > > But well, breaking Linux build in common distros isn't good either, so I > guess it makes sense to revert this while distros toolchains are being > fixed. Hopefully, it won't take too long. > > What do you think? Yes, we need to revert the change since it's a regression otherwise. I think the best course of action here would be to find a way that we can either tell the linker that it doesn't need the missing linker scripts because we're providing our own, or find a way to pass different LD flags depending on whether or not we have a linux toolchain. For now, I've pushed the revert to for-next/fixes. Will