From: Eduardo Habkost <ehabkost@redhat.com>
To: Dou Liyang <douly.fnst@cn.fujitsu.com>
Cc: Igor Mammedov <imammedo@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2] hw/machine: Remove the Zero check of nb_numa_nodes for numa_complete_configuration()
Date: Tue, 10 Jul 2018 07:27:03 -0300 [thread overview]
Message-ID: <20180710102703.GF7451@localhost.localdomain> (raw)
In-Reply-To: <2052cdff-3dea-1267-3442-39557637b2d4@cn.fujitsu.com>
On Tue, Jul 10, 2018 at 04:15:30PM +0800, Dou Liyang wrote:
[...]
> > > + if (nb_numa_nodes)
> > > machine_numa_finish_cpu_init(machine);
> > > - }
> > missing curly brackets, should look like:
> > if (nb_numa_nodes) {
> > machine_numa_finish_cpu_init(machine);
> > }
> >
> > with that fixed
> > Reviewed-by: Igor Mammedov <imammedo@redhat.com>
> >
>
> Thank you, Igor.
>
> Due to Eduardo has sent the pull request of this patch,
> Can I fix this and send v2 patch now?
You can fix this on a follow-up patch and CC qemu-trivial.
--
Eduardo
next prev parent reply other threads:[~2018-07-10 10:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-04 13:22 [Qemu-devel] [PATCH v2] hw/machine: Remove the Zero check of nb_numa_nodes for numa_complete_configuration() Dou Liyang
2018-07-04 13:31 ` no-reply
2018-07-04 18:06 ` Eduardo Habkost
2018-07-10 7:42 ` Igor Mammedov
2018-07-10 8:15 ` Dou Liyang
2018-07-10 10:27 ` Eduardo Habkost [this message]
2018-07-10 10:33 ` Dou Liyang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180710102703.GF7451@localhost.localdomain \
--to=ehabkost@redhat.com \
--cc=douly.fnst@cn.fujitsu.com \
--cc=imammedo@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.