From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Peter Xu <peterx@redhat.com>
Cc: qemu-devel@nongnu.org, Juan Quintela <quintela@redhat.com>
Subject: Re: [Qemu-devel] [PATCH for-3.0] migration: reorder MIG_CMD_POSTCOPY_RESUME
Date: Tue, 10 Jul 2018 13:19:29 +0100 [thread overview]
Message-ID: <20180710121929.GB37263@work-vm> (raw)
In-Reply-To: <20180710094424.30754-1-peterx@redhat.com>
* Peter Xu (peterx@redhat.com) wrote:
> It was accidently added before MIG_CMD_PACKAGED so it might break
> command compatibility when we run postcopy migration between old/new
> QEMUs. Fix that up quickly before the QEMU 3.0 release.
>
> Reported-by: Lukáš Doktor <ldoktor@redhat.com>
> Suggested-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> Signed-off-by: Peter Xu <peterx@redhat.com>
Queued
> ---
> migration/savevm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/migration/savevm.c b/migration/savevm.c
> index c2f34ffc7c..0d2c4a0739 100644
> --- a/migration/savevm.c
> +++ b/migration/savevm.c
> @@ -81,8 +81,8 @@ enum qemu_vm_cmd {
> MIG_CMD_POSTCOPY_RAM_DISCARD, /* A list of pages to discard that
> were previously sent during
> precopy but are dirty. */
> - MIG_CMD_POSTCOPY_RESUME, /* resume postcopy on dest */
> MIG_CMD_PACKAGED, /* Send a wrapped stream within this stream */
> + MIG_CMD_POSTCOPY_RESUME, /* resume postcopy on dest */
> MIG_CMD_RECV_BITMAP, /* Request for recved bitmap on dst */
> MIG_CMD_MAX
> };
> --
> 2.17.1
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
next prev parent reply other threads:[~2018-07-10 12:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-10 9:44 [Qemu-devel] [PATCH for-3.0] migration: reorder MIG_CMD_POSTCOPY_RESUME Peter Xu
2018-07-10 9:57 ` Dr. David Alan Gilbert
2018-07-10 12:19 ` Dr. David Alan Gilbert [this message]
2018-07-10 12:22 ` Juan Quintela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180710121929.GB37263@work-vm \
--to=dgilbert@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.