From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Jack Wang <jack.wang.usish@gmail.com>
Cc: kamensky@cisco.com, stable@vger.kernel.org, mhiramat@kernel.org,
systemtap@sourceware.org, xe-linux-external@cisco.com,
amakhalov@vmware.com
Subject: Re: in stable 4.4.131 kprobes seems to be broken
Date: Tue, 10 Jul 2018 15:31:06 +0200 [thread overview]
Message-ID: <20180710133106.GA20816@kroah.com> (raw)
In-Reply-To: <CA+res+ScSF2y1JBd7f0sv3V8p4WvDYy6LXqpRo4keh=m5DiNfA@mail.gmail.com>
On Tue, Jul 10, 2018 at 02:26:43PM +0200, Jack Wang wrote:
> > That commit seems to be part of some x86 kprobes restructuring, I
> > hesitated to try it. After your email tried to cherry-pick to 4.4.y
> > and it does not go in smoothly at all, quite a bit of conflicts.
> >
> > I may not phrase it correctly: My point was that in 4.4 there
> > are more places where synthesize_reljump function is called, which
> > latter got removed. And this function modifies kprobes page, so
> > lifting up read-only protection needs to be done in more places
> > compared to latter kernels. Whether it can be done correctly and
> > proper thing to do in do_debug/resume_execution function
> > exception processing context I cannot tell.
> >
> > Thanks,
> > Victor
> >
> > > thanks,
> > >
> > > greg k-h
> > >
> Hi Victor, Hi Greg,
>
> Alexey Makhalov (+cc) ported the fix to kernel 4.4 2 weeks ago.
> https://www.spinics.net/lists/stable/msg245223.html
>
> It applies cleanly to 4.4.139.
Ah, nice, that's already queued up and will be in the next 4.4.y release
in a few days.
thanks,
greg k-h
next prev parent reply other threads:[~2018-07-10 13:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <alpine.LRH.2.00.1807092352480.31641@sjc-ads-6991.cisco.com>
2018-07-10 7:05 ` in stable 4.4.131 kprobes seems to be broken Greg Kroah-Hartman
2018-07-10 7:32 ` Victor Kamensky
2018-07-10 12:26 ` Jack Wang
2018-07-10 13:31 ` Greg Kroah-Hartman [this message]
2018-07-11 13:22 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180710133106.GA20816@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=amakhalov@vmware.com \
--cc=jack.wang.usish@gmail.com \
--cc=kamensky@cisco.com \
--cc=mhiramat@kernel.org \
--cc=stable@vger.kernel.org \
--cc=systemtap@sourceware.org \
--cc=xe-linux-external@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.