From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-owner@vger.kernel.org>
Received: from mail.linuxfoundation.org ([140.211.169.12]:39442 "EHLO
        mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S933431AbeGJODi (ORCPT
        <rfc822;stable@vger.kernel.org>); Tue, 10 Jul 2018 10:03:38 -0400
Date: Tue, 10 Jul 2018 16:03:35 +0200
From: Greg KH <gregkh@linuxfoundation.org>
To: Jiri Slaby <jslaby@suse.cz>
Cc: David Miller <davem@davemloft.net>, stable@vger.kernel.org,
        madalin.bucur@nxp.com
Subject: Re: dpaa_eth bad stable backport [was: [PATCHES] Networking]
Message-ID: <20180710140335.GJ1123@kroah.com>
References: <20180328.113510.98892181272784815.davem@davemloft.net>
 <32445611-cc59-2f30-1708-e1c8ade6171a@suse.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <32445611-cc59-2f30-1708-e1c8ade6171a@suse.cz>
Sender: stable-owner@vger.kernel.org
List-ID: <stable.vger.kernel.org>

On Thu, Jun 28, 2018 at 04:24:24PM +0200, Jiri Slaby wrote:
> On 03/28/2018, 05:35 PM, David Miller wrote:
> > Please queue up the following networking bug fixes for v4.14 and v4.15
> > -stable, respecetively.
> 
> Hi,
> 
> I wonder if this commit from this batch is correct in 4.14 and 4.15:
> commit 5bbb99d2fde047df596379be6c58e265e2ddbe1f
> Author: Madalin Bucur <madalin.bucur@nxp.com>
> Date:   Wed Mar 14 08:37:29 2018 -0500
> 
>     dpaa_eth: fix error in dpaa_remove()
> 
>     [ Upstream commit 88075256ee817041d68c2387f29065b5cb2b342a ]
> 
> 
> 
> In 4.14 and 4.15, the drvdata are set like this:
>         dev = &pdev->dev;
> …
>         dev_set_drvdata(dev, net_dev);
> 
> Opposing to 4.16:
>         dev = pdev->dev.parent;
> …
>         dev_set_drvdata(dev, net_dev);
> 
> 
> 
> 
> So the change in dpaa_remove done by the commit above is wrong IMO:
> -       dev = &pdev->dev;
> +       dev = pdev->dev.parent;
>         net_dev = dev_get_drvdata(dev);
> 
> 
> 
> Hence this should be reverted from 4.14-LTS. I think 4.15 is dead.

Now reverted, thanks.

greg k-h