From: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
To: Robin Murphy <robin.murphy-5wv7dgnIgG8@public.gmane.org>
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org,
x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
Palmer Dabbelt <palmer-SpMDHPYPyPbQT0dZR+AlfA@public.gmane.org>,
sudeep.holla-5wv7dgnIgG8@public.gmane.org,
linux-riscv-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
frowand.list-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [RFC PATCH 0/4] Stop losing firmware-set DMA masks
Date: Tue, 10 Jul 2018 20:02:32 +0200 [thread overview]
Message-ID: <20180710180232.GA26285@lst.de> (raw)
In-Reply-To: <cover.1531239284.git.robin.murphy-5wv7dgnIgG8@public.gmane.org>
> These patches attempt to deal with this in the simplest way possible by
> generalising the specific quirk for 32-bit bridges into an arbitrary
> mask which can then also be plumbed into the firmware code. In the
> interest of being minimally invasive, I've only included a point fix
> for the IOMMU issue as seen on arm64 - there may be further tweaks
> needed in DMA ops to catch all possible incarnations of this problem,
> but this initial RFC is mostly about the impact beyond the dma-mapping
> subsystem itself.
Thanks, this looks very nice to me.
In fact it probably solves the RISC-V/Xiling problem as well if we can
just add the dma-ranges property to the device tree for the affected
systems. Palmer, do you know how easily the DT could be updated for
that case?
>
> Robin.
>
>
> [1] http://lists.infradead.org/pipermail/linux-arm-kernel/2018-May/580804.html
> [2] http://lists.infradead.org/pipermail/linux-arm-kernel/2016-December/474443.html
>
> Robin Murphy (4):
> dma-mapping: Generalise dma_32bit_limit flag
> ACPI/IORT: Set bus DMA mask as appropriate
> of/device: Set bus DMA mask as appropriate
> iommu/dma: Respect bus DMA limit for IOVAs
>
> arch/x86/kernel/pci-dma.c | 2 +-
> drivers/acpi/arm64/iort.c | 1 +
> drivers/iommu/dma-iommu.c | 3 +++
> drivers/of/device.c | 1 +
> include/linux/device.h | 6 +++---
> kernel/dma/direct.c | 2 +-
> 6 files changed, 10 insertions(+), 5 deletions(-)
>
> --
> 2.17.1.dirty
---end quoted text---
WARNING: multiple messages have this Message-ID (diff)
From: hch@lst.de (Christoph Hellwig)
To: linux-riscv@lists.infradead.org
Subject: [RFC PATCH 0/4] Stop losing firmware-set DMA masks
Date: Tue, 10 Jul 2018 20:02:32 +0200 [thread overview]
Message-ID: <20180710180232.GA26285@lst.de> (raw)
In-Reply-To: <cover.1531239284.git.robin.murphy@arm.com>
> These patches attempt to deal with this in the simplest way possible by
> generalising the specific quirk for 32-bit bridges into an arbitrary
> mask which can then also be plumbed into the firmware code. In the
> interest of being minimally invasive, I've only included a point fix
> for the IOMMU issue as seen on arm64 - there may be further tweaks
> needed in DMA ops to catch all possible incarnations of this problem,
> but this initial RFC is mostly about the impact beyond the dma-mapping
> subsystem itself.
Thanks, this looks very nice to me.
In fact it probably solves the RISC-V/Xiling problem as well if we can
just add the dma-ranges property to the device tree for the affected
systems. Palmer, do you know how easily the DT could be updated for
that case?
>
> Robin.
>
>
> [1] http://lists.infradead.org/pipermail/linux-arm-kernel/2018-May/580804.html
> [2] http://lists.infradead.org/pipermail/linux-arm-kernel/2016-December/474443.html
>
> Robin Murphy (4):
> dma-mapping: Generalise dma_32bit_limit flag
> ACPI/IORT: Set bus DMA mask as appropriate
> of/device: Set bus DMA mask as appropriate
> iommu/dma: Respect bus DMA limit for IOVAs
>
> arch/x86/kernel/pci-dma.c | 2 +-
> drivers/acpi/arm64/iort.c | 1 +
> drivers/iommu/dma-iommu.c | 3 +++
> drivers/of/device.c | 1 +
> include/linux/device.h | 6 +++---
> kernel/dma/direct.c | 2 +-
> 6 files changed, 10 insertions(+), 5 deletions(-)
>
> --
> 2.17.1.dirty
---end quoted text---
WARNING: multiple messages have this Message-ID (diff)
From: hch@lst.de (Christoph Hellwig)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH 0/4] Stop losing firmware-set DMA masks
Date: Tue, 10 Jul 2018 20:02:32 +0200 [thread overview]
Message-ID: <20180710180232.GA26285@lst.de> (raw)
In-Reply-To: <cover.1531239284.git.robin.murphy@arm.com>
> These patches attempt to deal with this in the simplest way possible by
> generalising the specific quirk for 32-bit bridges into an arbitrary
> mask which can then also be plumbed into the firmware code. In the
> interest of being minimally invasive, I've only included a point fix
> for the IOMMU issue as seen on arm64 - there may be further tweaks
> needed in DMA ops to catch all possible incarnations of this problem,
> but this initial RFC is mostly about the impact beyond the dma-mapping
> subsystem itself.
Thanks, this looks very nice to me.
In fact it probably solves the RISC-V/Xiling problem as well if we can
just add the dma-ranges property to the device tree for the affected
systems. Palmer, do you know how easily the DT could be updated for
that case?
>
> Robin.
>
>
> [1] http://lists.infradead.org/pipermail/linux-arm-kernel/2018-May/580804.html
> [2] http://lists.infradead.org/pipermail/linux-arm-kernel/2016-December/474443.html
>
> Robin Murphy (4):
> dma-mapping: Generalise dma_32bit_limit flag
> ACPI/IORT: Set bus DMA mask as appropriate
> of/device: Set bus DMA mask as appropriate
> iommu/dma: Respect bus DMA limit for IOVAs
>
> arch/x86/kernel/pci-dma.c | 2 +-
> drivers/acpi/arm64/iort.c | 1 +
> drivers/iommu/dma-iommu.c | 3 +++
> drivers/of/device.c | 1 +
> include/linux/device.h | 6 +++---
> kernel/dma/direct.c | 2 +-
> 6 files changed, 10 insertions(+), 5 deletions(-)
>
> --
> 2.17.1.dirty
---end quoted text---
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Robin Murphy <robin.murphy@arm.com>
Cc: m.szyprowski@samsung.com, iommu@lists.linux-foundation.org,
linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
lorenzo.pieralisi@arm.com, hanjun.guo@linaro.org,
sudeep.holla@arm.com, robh+dt@kernel.org, frowand.list@gmail.com,
gregkh@linuxfoundation.org, joro@8bytes.org, x86@kernel.org,
Palmer Dabbelt <palmer@sifive.com>,
linux-riscv@lists.infradead.org
Subject: Re: [RFC PATCH 0/4] Stop losing firmware-set DMA masks
Date: Tue, 10 Jul 2018 20:02:32 +0200 [thread overview]
Message-ID: <20180710180232.GA26285@lst.de> (raw)
In-Reply-To: <cover.1531239284.git.robin.murphy@arm.com>
> These patches attempt to deal with this in the simplest way possible by
> generalising the specific quirk for 32-bit bridges into an arbitrary
> mask which can then also be plumbed into the firmware code. In the
> interest of being minimally invasive, I've only included a point fix
> for the IOMMU issue as seen on arm64 - there may be further tweaks
> needed in DMA ops to catch all possible incarnations of this problem,
> but this initial RFC is mostly about the impact beyond the dma-mapping
> subsystem itself.
Thanks, this looks very nice to me.
In fact it probably solves the RISC-V/Xiling problem as well if we can
just add the dma-ranges property to the device tree for the affected
systems. Palmer, do you know how easily the DT could be updated for
that case?
>
> Robin.
>
>
> [1] http://lists.infradead.org/pipermail/linux-arm-kernel/2018-May/580804.html
> [2] http://lists.infradead.org/pipermail/linux-arm-kernel/2016-December/474443.html
>
> Robin Murphy (4):
> dma-mapping: Generalise dma_32bit_limit flag
> ACPI/IORT: Set bus DMA mask as appropriate
> of/device: Set bus DMA mask as appropriate
> iommu/dma: Respect bus DMA limit for IOVAs
>
> arch/x86/kernel/pci-dma.c | 2 +-
> drivers/acpi/arm64/iort.c | 1 +
> drivers/iommu/dma-iommu.c | 3 +++
> drivers/of/device.c | 1 +
> include/linux/device.h | 6 +++---
> kernel/dma/direct.c | 2 +-
> 6 files changed, 10 insertions(+), 5 deletions(-)
>
> --
> 2.17.1.dirty
---end quoted text---
next prev parent reply other threads:[~2018-07-10 18:02 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-10 17:17 [RFC PATCH 0/4] Stop losing firmware-set DMA masks Robin Murphy
2018-07-10 17:17 ` Robin Murphy
2018-07-10 17:17 ` Robin Murphy
[not found] ` <cover.1531239284.git.robin.murphy-5wv7dgnIgG8@public.gmane.org>
2018-07-10 17:17 ` [RFC PATCH 1/4] dma-mapping: Generalise dma_32bit_limit flag Robin Murphy
2018-07-10 17:17 ` Robin Murphy
2018-07-10 17:17 ` Robin Murphy
2018-07-10 18:04 ` Christoph Hellwig
2018-07-10 18:04 ` Christoph Hellwig
2018-07-10 18:04 ` Christoph Hellwig
2018-07-11 16:56 ` Robin Murphy
2018-07-11 16:56 ` Robin Murphy
[not found] ` <868cead9-88a7-e58d-3452-a78e19be5f47-5wv7dgnIgG8@public.gmane.org>
2018-07-12 7:20 ` Christoph Hellwig
2018-07-12 7:20 ` Christoph Hellwig
2018-07-12 7:20 ` Christoph Hellwig
2018-07-10 18:02 ` Christoph Hellwig [this message]
2018-07-10 18:02 ` [RFC PATCH 0/4] Stop losing firmware-set DMA masks Christoph Hellwig
2018-07-10 18:02 ` Christoph Hellwig
2018-07-10 18:02 ` Christoph Hellwig
[not found] ` <20180710180232.GA26285-jcswGhMUV9g@public.gmane.org>
2018-07-10 18:11 ` Robin Murphy
2018-07-10 18:11 ` Robin Murphy
2018-07-10 18:11 ` Robin Murphy
2018-07-10 18:11 ` Robin Murphy
2018-07-10 18:12 ` Atish Patra
2018-07-10 18:12 ` Atish Patra
2018-07-10 18:12 ` Atish Patra
2018-07-10 17:17 ` [RFC PATCH 2/4] ACPI/IORT: Set bus DMA mask as appropriate Robin Murphy
2018-07-10 17:17 ` Robin Murphy
2018-07-10 17:17 ` Robin Murphy
[not found] ` <c604b3eae4103ee0ad6da84baa1bc893a81ef5f8.1531239284.git.robin.murphy-5wv7dgnIgG8@public.gmane.org>
2018-07-10 18:04 ` Christoph Hellwig
2018-07-10 18:04 ` Christoph Hellwig
2018-07-10 18:04 ` Christoph Hellwig
[not found] ` <20180710180458.GC26285-jcswGhMUV9g@public.gmane.org>
2018-07-11 18:03 ` Robin Murphy
2018-07-11 18:03 ` Robin Murphy
2018-07-11 18:03 ` Robin Murphy
2018-07-10 17:17 ` [RFC PATCH 3/4] of/device: " Robin Murphy
2018-07-10 17:17 ` Robin Murphy
2018-07-10 17:17 ` Robin Murphy
2018-07-10 17:17 ` [RFC PATCH 4/4] iommu/dma: Respect bus DMA limit for IOVAs Robin Murphy
2018-07-10 17:17 ` Robin Murphy
2018-07-10 17:17 ` Robin Murphy
2018-07-11 14:40 ` [RFC PATCH 0/4] Stop losing firmware-set DMA masks Rob Herring
2018-07-11 14:40 ` Rob Herring
[not found] ` <CABGGisxVqLMu3TUpbJGWnUFgzUor-8tdyV8KJeU0YT7y=BHrAQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-07-11 16:03 ` Robin Murphy
2018-07-11 16:03 ` Robin Murphy
2018-07-11 16:03 ` Robin Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180710180232.GA26285@lst.de \
--to=hch-jcswghmuv9g@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=frowand.list-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-riscv-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=palmer-SpMDHPYPyPbQT0dZR+AlfA@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=robin.murphy-5wv7dgnIgG8@public.gmane.org \
--cc=sudeep.holla-5wv7dgnIgG8@public.gmane.org \
--cc=x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.