From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH net-next v2 02/10] r8169: use phy_resume/phy_suspend
Date: Tue, 10 Jul 2018 21:15:09 +0200
Message-ID: <20180710191509.GC11754@lunn.ch>
References: <84ac1cb7-bafd-5f15-8cda-e8dfd7d0deb3@gmail.com>
 <a5f58c73-fcfa-8f19-99d6-a0860ca91fc3@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: David Miller <davem@davemloft.net>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Realtek linux nic maintainers <nic_swsd@realtek.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
To: Heiner Kallweit <hkallweit1@gmail.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from vps0.lunn.ch ([185.16.172.187]:57829 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1732502AbeGJTPi (ORCPT <rfc822;netdev@vger.kernel.org>);
        Tue, 10 Jul 2018 15:15:38 -0400
Content-Disposition: inline
In-Reply-To: <a5f58c73-fcfa-8f19-99d6-a0860ca91fc3@gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

>  static void r8168_pll_power_down(struct rtl8169_private *tp)
>  {
>  	if (r8168_check_dash(tp))
> @@ -4503,7 +4462,8 @@ static void r8168_pll_power_down(struct rtl8169_private *tp)
>  	if (rtl_wol_pll_power_down(tp))
>  		return;
>  
> -	r8168_phy_power_down(tp);
> +	/* cover the case that PHY isn't connected */
> +	phy_suspend(mdiobus_get_phy(tp->mii_bus, 0));

I don't particularly like this, because no other MAC driver does it.

Why is it powered up, but not connected? Is it powered down before it
is disconnected? Is it the bootloader which is powering it up?

   Andrew