From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH net-next v2 09/10] r8169: remove mii_if_info member from
 struct rtl8169_private
Date: Tue, 10 Jul 2018 23:00:36 +0200
Message-ID: <20180710210036.GK892@lunn.ch>
References: <84ac1cb7-bafd-5f15-8cda-e8dfd7d0deb3@gmail.com>
 <aaa67fd8-9039-0786-96fa-0803db280c97@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: David Miller <davem@davemloft.net>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Realtek linux nic maintainers <nic_swsd@realtek.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
To: Heiner Kallweit <hkallweit1@gmail.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from vps0.lunn.ch ([185.16.172.187]:58060 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1732205AbeGJVgL (ORCPT <rfc822;netdev@vger.kernel.org>);
        Tue, 10 Jul 2018 17:36:11 -0400
Content-Disposition: inline
In-Reply-To: <aaa67fd8-9039-0786-96fa-0803db280c97@gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

> @@ -6719,7 +6703,7 @@ static int r8169_phy_connect(struct rtl8169_private *tp)
>  	if (ret)
>  		return ret;
>  
> -	if (!tp->mii.supports_gmii && phydev->supported & PHY_1000BT_FEATURES) {
> +	if (!tp->supports_gmii && phydev->supported & PHY_1000BT_FEATURES) {

It is better to use phy_set_max_speed() with SPEED_100 if
tp->supports_gmii is not set.

	  Andrew