From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Look for an active kernel context before switching
Date: Tue, 10 Jul 2018 14:27:05 -0700 [thread overview]
Message-ID: <20180710212705.GG9764@intel.com> (raw)
In-Reply-To: <153125333728.18500.7446656447710521132@skylake-alporthouse-com>
On Tue, Jul 10, 2018 at 09:09:07PM +0100, Chris Wilson wrote:
> Quoting Rodrigo Vivi (2018-07-10 20:59:26)
> > Hi Chris, this failed the cherry-pick for drm-intel-fixes, but looking
> > to the log it seems something we want there right?!
>
> It didn't become crucial until a later patch:
>
> commit 4dfacb0bcbee79fa2ef4b2e9e64a8f8a28598934
> Author: Chris Wilson <chris@chris-wilson.co.uk>
> Date: Thu May 31 09:22:43 2018 +0100
>
> drm/i915: Switch to kernel context before idling at runtime
>
> Before that patch we just occasionally emitted one more request that we
> strictly required (bumping suspend times by a few microseconds). With
> that patch, we would hit an infinite loop unless we applied the fix.
>
> So while it did fix a recent bug, impact is minimal.
Cool then. Thanks for the explanation.
> -Chris
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-07-10 21:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-24 8:11 [PATCH] drm/i915: Look for an active kernel context before switching Chris Wilson
2018-05-24 13:11 ` ✓ Fi.CI.BAT: success for drm/i915: Look for an active kernel context before switching (rev2) Patchwork
2018-05-24 13:37 ` ✓ Fi.CI.IGT: " Patchwork
2018-05-24 14:40 ` [PATCH] drm/i915: Look for an active kernel context before switching Mika Kuoppala
2018-05-24 14:51 ` Chris Wilson
2018-07-10 19:59 ` Rodrigo Vivi
2018-07-10 20:09 ` Chris Wilson
2018-07-10 21:27 ` Rodrigo Vivi [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-05-23 8:04 Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180710212705.GG9764@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.