From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Date: Wed, 11 Jul 2018 09:14:16 +0200 Subject: [U-Boot] [PATCH 5/8] phy: sun4i-usb: Update PHY#3 rst_mask only for H3_H5 In-Reply-To: References: <20180709191710.22446-1-jagan@amarulasolutions.com> <20180709191710.22446-6-jagan@amarulasolutions.com> Message-ID: <20180711071416.ptg5hfxbecv7ecqd@flea> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wed, Jul 11, 2018 at 12:37:04PM +0530, Jagan Teki wrote: > On Wed, Jul 11, 2018 at 12:23 PM, Vasily Khoruzhick wrote: > > On Mon, Jul 9, 2018 at 12:17 PM, Jagan Teki wrote: > >> Only H3 and H5 have 4 PHYS so restrict rst_mask only for them. > >> > >> Signed-off-by: Jagan Teki > >> --- > >> drivers/phy/allwinner/phy-sun4i-usb.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/drivers/phy/allwinner/phy-sun4i-usb.c b/drivers/phy/allwinner/phy-sun4i-usb.c > >> index 3096f12c1c..81fcd1f910 100644 > >> --- a/drivers/phy/allwinner/phy-sun4i-usb.c > >> +++ b/drivers/phy/allwinner/phy-sun4i-usb.c > >> @@ -117,7 +117,7 @@ struct sun4i_usb_phy_info { > >> .gpio_vbus = CONFIG_USB3_VBUS_PIN, > >> .gpio_vbus_det = NULL, > >> .gpio_id_det = NULL, > >> -#ifdef CONFIG_MACH_SUN6I > >> +#ifdef CONFIG_MACH_SUNXI_H3_H5 > > > > It should be handled by compatibles, not ifdefs. Phy driver is proper > > DM driver, so you can use .data in device ids array. > > True, but since it' already have ifdef and more over this code will > drop very soon, we are planning to support CLK and RST[1] (max of > v2018.11). Says who? I'd really prefer to have something when it's ready, rather than trying to push to meet a deadline that we enforced on ourselves, and end up with a tons of bugs to fix. The latest PHY patches should be a pretty good example on why we *shouldn't* do that. Maxime -- Maxime Ripard, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 833 bytes Desc: not available URL: