From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [02/14] dmaengine: dma-jz4780: Separate chan/ctrl registers From: Vinod Koul Message-Id: <20180711121655.GS3219@vkoul-mobl> Date: Wed, 11 Jul 2018 17:46:55 +0530 To: Paul Cercueil Cc: Rob Herring , Mark Rutland , Ralf Baechle , Paul Burton , James Hogan , Zubair Lutfullah Kakakhel , Mathieu Malaterre , Daniel Silsby , dmaengine@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@linux-mips.org List-ID: T24gMTAtMDctMTgsIDE3OjM2LCBQYXVsIENlcmN1ZWlsIHdyb3RlOgoKPiA+ID4gIEBAIC0zLDcg KzMsOCBAQAo+ID4gPiAgIFJlcXVpcmVkIHByb3BlcnRpZXM6Cj4gPiA+IAo+ID4gPiAgIC0gY29t cGF0aWJsZTogU2hvdWxkIGJlICJpbmdlbmljLGp6NDc4MC1kbWEiCj4gPiA+ICAtLSByZWc6IFNo b3VsZCBjb250YWluIHRoZSBETUEgY29udHJvbGxlciByZWdpc3RlcnMgbG9jYXRpb24gYW5kCj4g PiA+IGxlbmd0aC4KPiA+ID4gICstIHJlZzogU2hvdWxkIGNvbnRhaW4gdGhlIERNQSBjaGFubmVs IHJlZ2lzdGVycyBsb2NhdGlvbiBhbmQKPiA+ID4gbGVuZ3RoLCBmb2xsb3dlZAo+ID4gPiAgKyAg YnkgdGhlIERNQSBjb250cm9sbGVyIHJlZ2lzdGVycyBsb2NhdGlvbiBhbmQgbGVuZ3RoLgo+ID4g PiAgIC0gaW50ZXJydXB0czogU2hvdWxkIGNvbnRhaW4gdGhlIGludGVycnVwdCBzcGVjaWZpZXIg b2YgdGhlIERNQQo+ID4gPiBjb250cm9sbGVyLgo+ID4gPiAgIC0gaW50ZXJydXB0LXBhcmVudDog U2hvdWxkIGJlIHRoZSBwaGFuZGxlIG9mIHRoZSBpbnRlcnJ1cHQKPiA+ID4gY29udHJvbGxlciB0 aGF0Cj4gPiA+ICAgLSBjbG9ja3M6IFNob3VsZCBjb250YWluIGEgY2xvY2sgc3BlY2lmaWVyIGZv ciB0aGUgSlo0NzgwIFBETUEKPiA+ID4gY2xvY2suCj4gPiA+ICBAQCAtMjIsNyArMjMsOCBAQCBF eGFtcGxlOgo+ID4gPiAKPiA+ID4gICBkbWE6IGRtYUAxMzQyMDAwMCB7Cj4gPiA+ICAgCWNvbXBh dGlibGUgPSAiaW5nZW5pYyxqejQ3ODAtZG1hIjsKPiA+ID4gIC0JcmVnID0gPDB4MTM0MjAwMDAg MHgxMDAwMD47Cj4gPiA+ICArCXJlZyA9IDwweDEzNDIwMDAwIDB4NDAwCj4gPiA+ICArCSAgICAg ICAweDEzNDIxMDAwIDB4NDA+Owo+ID4gCj4gPiBTZWNvbmQgc2hvdWxkIGJlIG9wdGlvbmFsIG9y IHdlIGJyZWFrIHBsYXRmb3JtIHdoaWNoIG1heSBub3QgaGF2ZQo+ID4gdXBkYXRlZCBEVC4uCj4g Cj4gU2VlIGNvbW1lbnQgYmVsb3cuCj4gCj4gPiA+ICAtCWp6ZG1hLT5iYXNlID0gZGV2bV9pb3Jl bWFwX3Jlc291cmNlKGRldiwgcmVzKTsKPiA+ID4gIC0JaWYgKElTX0VSUihqemRtYS0+YmFzZSkp Cj4gPiA+ICAtCQlyZXR1cm4gUFRSX0VSUihqemRtYS0+YmFzZSk7Cj4gPiA+ICArCWp6ZG1hLT5j aG5fYmFzZSA9IGRldm1faW9yZW1hcF9yZXNvdXJjZShkZXYsIHJlcyk7Cj4gPiA+ICArCWlmIChJ U19FUlIoanpkbWEtPmNobl9iYXNlKSkKPiA+ID4gICsJCXJldHVybiBQVFJfRVJSKGp6ZG1hLT5j aG5fYmFzZSk7Cj4gPiA+ICArCj4gPiA+ICArCXJlcyA9IHBsYXRmb3JtX2dldF9yZXNvdXJjZShw ZGV2LCBJT1JFU09VUkNFX01FTSwgMSk7Cj4gPiA+ICArCWlmICghcmVzKSB7Cj4gPiA+ICArCQlk ZXZfZXJyKGRldiwgImZhaWxlZCB0byBnZXQgSS9PIG1lbW9yeVxuIik7Cj4gPiA+ICArCQlyZXR1 cm4gLUVJTlZBTDsKPiA+ID4gICsJfQo+ID4gCj4gPiBva2F5IGFuZCB0aGlzIGJyZWFrcyBpZiB5 b3UgaGFwcGVuIHRvIGdldCBwcm9iZWQgb24gb2xkZXIgRFQuIEkgdGhpbmsgRFQKPiA+IGlzIHRy ZWF0ZWQgYXMgQUJJIHNvIHlvdSBuZWVkIHRvIGNvbnRpbnVlIHN1cHBvcnQgb2xkZXIgbWV0aG9k IHdoaWxlCj4gPiBmaW5kaW5nIGlmIERUIGhhcyBzcGxpdCByZXNvdXJjZXMKPiAKPiBTZWUgbXkg cmVzcG9uc2UgdG8gUHJhc2FubmFLdW1hci4gQWxsIHRoZSBJbmdlbmljLWJhc2VkIGJvYXJkcyBk byBjb21waWxlCj4gdGhlIGRldmljZXRyZWUgd2l0aGluIHRoZSBrZXJuZWwsIHNvIEkgdGhpbmsg aXQncyBzdGlsbCBmaW5lIHRvIGFkZCBicmVha2luZwo+IGNoYW5nZXMuIEknbGwgd2FpdCBvbiBA Um9iIHRvIGdpdmUgaGlzIHBvaW50IG9mIHZpZXcgb24gdGhpcywgdGhvdWdoLgo+IAo+IChJdCdz IG5vdCBzb21ldGhpbmcgaGFyZCB0byBjaGFuZ2UsIGJ1dCBJJ2QgbGlrZSB0byBrbm93IHdoYXQn cyB0aGUgcG9saWN5Cj4gaW4gdGhhdCBjYXNlLiBJIGhhdmUgb3RoZXIgRFQtYnJlYWtpbmcgcGF0 Y2hlcyB0byBzdWJtaXQpCgpUaGUgcG9saWN5IGlzIHRoYXQgRFQgaXMgYW4gQUJJIGFuZCBzaG91 bGQgbm90IGJyZWFrIDopCgpXaG8gbWFpbnRhaW5zIEluZ2VuaWMgYXJjaC4gTUFJTlRBSU5FUlMg ZG9lc24ndCB0ZWxsIG1lLgo= From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Wed, 11 Jul 2018 14:17:19 +0200 (CEST) Received: from mail.kernel.org ([198.145.29.99]:51778 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S23993577AbeGKMRKWAuf0 (ORCPT ); Wed, 11 Jul 2018 14:17:10 +0200 Received: from localhost (unknown [106.200.243.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6DFB72084A; Wed, 11 Jul 2018 12:17:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1531311424; bh=7MPLgS8jcq32VU6ZOl+aL6zKzSYkVQuVD8gwoppUNW0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kQ0REPasqeQ6hjZSrqYY4mTMwfHtAXyuhNc3dtssPMClTTRZnlrxD0VEIdWJurI/a 4qZI8tD1eQRNsOSnUgnNbpMz5e2Gh4cf34v7V5ZW+azYG7PpW4NtNRrUcBWlWsQVee dWOz/5r49HY+PVbQDOGAQ6p205q8CI0TuXYMUDKw= Date: Wed, 11 Jul 2018 17:46:55 +0530 From: Vinod To: Paul Cercueil Cc: Rob Herring , Mark Rutland , Ralf Baechle , Paul Burton , James Hogan , Zubair Lutfullah Kakakhel , Mathieu Malaterre , Daniel Silsby , dmaengine@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@linux-mips.org Subject: Re: [PATCH 02/14] dmaengine: dma-jz4780: Separate chan/ctrl registers Message-ID: <20180711121655.GS3219@vkoul-mobl> References: <20180703123214.23090-1-paul@crapouillou.net> <20180703123214.23090-3-paul@crapouillou.net> <20180709170359.GI22377@vkoul-mobl> <1531237019.17118.1@crapouillou.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1531237019.17118.1@crapouillou.net> User-Agent: Mutt/1.9.2 (2017-12-15) Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 64790 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: vkoul@kernel.org Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips On 10-07-18, 17:36, Paul Cercueil wrote: > > > @@ -3,7 +3,8 @@ > > > Required properties: > > > > > > - compatible: Should be "ingenic,jz4780-dma" > > > -- reg: Should contain the DMA controller registers location and > > > length. > > > +- reg: Should contain the DMA channel registers location and > > > length, followed > > > + by the DMA controller registers location and length. > > > - interrupts: Should contain the interrupt specifier of the DMA > > > controller. > > > - interrupt-parent: Should be the phandle of the interrupt > > > controller that > > > - clocks: Should contain a clock specifier for the JZ4780 PDMA > > > clock. > > > @@ -22,7 +23,8 @@ Example: > > > > > > dma: dma@13420000 { > > > compatible = "ingenic,jz4780-dma"; > > > - reg = <0x13420000 0x10000>; > > > + reg = <0x13420000 0x400 > > > + 0x13421000 0x40>; > > > > Second should be optional or we break platform which may not have > > updated DT.. > > See comment below. > > > > - jzdma->base = devm_ioremap_resource(dev, res); > > > - if (IS_ERR(jzdma->base)) > > > - return PTR_ERR(jzdma->base); > > > + jzdma->chn_base = devm_ioremap_resource(dev, res); > > > + if (IS_ERR(jzdma->chn_base)) > > > + return PTR_ERR(jzdma->chn_base); > > > + > > > + res = platform_get_resource(pdev, IORESOURCE_MEM, 1); > > > + if (!res) { > > > + dev_err(dev, "failed to get I/O memory\n"); > > > + return -EINVAL; > > > + } > > > > okay and this breaks if you happen to get probed on older DT. I think DT > > is treated as ABI so you need to continue support older method while > > finding if DT has split resources > > See my response to PrasannaKumar. All the Ingenic-based boards do compile > the devicetree within the kernel, so I think it's still fine to add breaking > changes. I'll wait on @Rob to give his point of view on this, though. > > (It's not something hard to change, but I'd like to know what's the policy > in that case. I have other DT-breaking patches to submit) The policy is that DT is an ABI and should not break :) Who maintains Ingenic arch. MAINTAINERS doesn't tell me. -- ~Vinod