From: Boris Brezillon <boris.brezillon@bootlin.com>
To: "Ralf Baechle" <ralf@linux-mips.org>,
linux-mips@linux-mips.org, "Rafał Miłecki" <zajec5@gmail.com>,
"Boris Brezillon" <boris.brezillon@bootlin.com>,
"Richard Weinberger" <richard@nod.at>,
"Miquel Raynal" <miquel.raynal@bootlin.com>,
linux-mtd@lists.infradead.org
Cc: linux-wireless@vger.kernel.org,
Marek Vasut <marek.vasut@gmail.com>,
Brian Norris <computersforpeace@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH v2 04/24] mtd: rawnand: s3c2410: Allow selection of this driver when COMPILE_TEST=y
Date: Wed, 11 Jul 2018 13:16:26 +0200 [thread overview]
Message-ID: <20180711131626.732967be@bbrezillon> (raw)
In-Reply-To: <20180709200945.30116-5-boris.brezillon@bootlin.com>
On Mon, 9 Jul 2018 22:09:25 +0200
Boris Brezillon <boris.brezillon@bootlin.com> wrote:
> It just makes NAND maintainers' life easier by allowing them to
> compile-test this driver without having ARCH_S3C24XX or ARCH_S3C64XX
> enabled.
>
> We add a dependency on HAS_IOMEM to make sure the driver compiles
> correctly, and a dependency on !IA64 because the {read,write}s{bwl}()
> accessors are not defined for this architecture.
I see that SPARC does not define those accessors either. So I guess we
should add depends on !SPARC.
Arnd, any other way to know when the platform implements
{read,write}s{bwl}() accessors?
>
> Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>
> ---
> drivers/mtd/nand/raw/Kconfig | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/raw/Kconfig b/drivers/mtd/nand/raw/Kconfig
> index 1488ad0a0199..e01b3da726c0 100644
> --- a/drivers/mtd/nand/raw/Kconfig
> +++ b/drivers/mtd/nand/raw/Kconfig
> @@ -119,7 +119,8 @@ config MTD_NAND_AU1550
>
> config MTD_NAND_S3C2410
> tristate "NAND Flash support for Samsung S3C SoCs"
> - depends on ARCH_S3C24XX || ARCH_S3C64XX
> + depends on ARCH_S3C24XX || ARCH_S3C64XX || COMPILE_TEST
> + depends on HAS_IOMEM && !IA64
> help
> This enables the NAND flash controller on the S3C24xx and S3C64xx
> SoCs
next prev parent reply other threads:[~2018-07-11 11:16 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-09 20:09 [PATCH v2 00/24] mtd: rawnand: Improve compile-test coverage Boris Brezillon
2018-07-09 20:09 ` [PATCH v2 01/24] mtd: rawnand: atmel: Use uintptr_t casts instead of unsigned int Boris Brezillon
2018-07-09 20:09 ` [PATCH v2 02/24] mtd: rawnand: atmel: Add an __iomem cast on gen_pool_dma_alloc() call Boris Brezillon
2018-07-09 20:09 ` [PATCH v2 03/24] mtd: rawnand: atmel: Allow selection of this driver when COMPILE_TEST=y Boris Brezillon
2018-07-09 20:09 ` [PATCH v2 04/24] mtd: rawnand: s3c2410: " Boris Brezillon
2018-07-11 11:16 ` Boris Brezillon [this message]
2018-07-11 11:27 ` Arnd Bergmann
2018-07-11 11:32 ` Boris Brezillon
2018-07-11 12:09 ` Arnd Bergmann
2018-07-11 13:01 ` Boris Brezillon
2018-07-09 20:09 ` [PATCH v2 05/24] mtd: rawnand: orion: Avoid direct inclusion of asm headers Boris Brezillon
2018-07-09 20:09 ` [PATCH v2 06/24] mtd: rawnand: orion: Allow selection of this driver when COMPILE_TEST=y Boris Brezillon
2018-07-09 20:09 ` [PATCH v2 07/24] mtd: rawnand: davinci: Stop doing iomem pointer <-> u32 conversions Boris Brezillon
2018-07-09 20:09 ` [PATCH v2 08/24] mtd: rawnand: davinci: Use uintptr_t casts instead of unsigned ones Boris Brezillon
2018-07-09 20:09 ` [PATCH v2 09/24] mtd: rawnand: davinci: Allow selection of this driver when COMPILE_TEST=y Boris Brezillon
2018-07-09 20:09 ` [PATCH v2 10/24] mtd: rawnand: sunxi: Add an U suffix to NFC_PAGE_OP definition Boris Brezillon
2018-07-09 20:09 ` [PATCH v2 11/24] mtd: rawnand: sunxi: Make sure ret is initialized in sunxi_nfc_read_byte() Boris Brezillon
2018-07-09 20:35 ` Arnd Bergmann
2018-07-09 21:00 ` Boris Brezillon
2018-07-09 20:09 ` [PATCH v2 12/24] mtd: rawnand: sunxi: Allow selection of this driver when COMPILE_TEST=y Boris Brezillon
2018-07-09 20:09 ` [PATCH v2 13/24] mtd: rawnand: fscm: Avoid collision on PC def when compiling for MIPS Boris Brezillon
2018-07-09 20:09 ` [PATCH v2 14/24] mtd: rawnand: fsmc: Use uintptr_t casts instead of unsigned ones Boris Brezillon
2018-07-09 20:09 ` [PATCH v2 15/24] mtd: rawnand: fsmc: Allow selection of this driver when COMPILE_TEST=y Boris Brezillon
2018-07-09 20:09 ` [PATCH v2 16/24] memory: fsl_ifc: " Boris Brezillon
2018-07-09 20:09 ` [PATCH v2 17/24] mtd: rawnand: fsl_ifc: Add an __iomem specifier on eccstat_regs Boris Brezillon
2018-07-09 20:09 ` [PATCH v2 18/24] mtd: rawnand: fsl_ifc: Allow selection of this driver when COMPILE_TEST=y Boris Brezillon
2018-07-09 20:09 ` [PATCH v2 19/24] MIPS: txx9: Move the ndfc.h header to include/linux/platform_data/txx9 Boris Brezillon
2018-07-09 20:09 ` [PATCH v2 20/24] mtd: rawnand: txx9ndfmc: Allow selection of this driver when COMPILE_TEST=y Boris Brezillon
2018-07-09 20:09 ` [PATCH v2 21/24] MIPS: jz4740: Move jz4740_nand.h header to include/linux/platform_data/jz4740 Boris Brezillon
2018-07-09 20:09 ` [PATCH v2 22/24] mtd: rawnand: jz4740: Allow selection of this driver when COMPILE_TEST=y Boris Brezillon
2018-07-09 20:09 ` [PATCH v2 23/24] mtd: rawnand: jz4780: Drop the dependency on MACH_JZ4780 Boris Brezillon
[not found] ` <CANc+2y5vjUpM_ikegaoKTtqehSmBY3y_r+1E6y93AoivRQqmfg@mail.gmail.com>
2018-07-10 17:10 ` Boris Brezillon
2018-07-11 17:24 ` PrasannaKumar Muralidharan
2018-07-09 20:09 ` [PATCH v2 24/24] memory: jz4780-nemc: Allow selection of this driver when COMPILE_TEST=y Boris Brezillon
2018-07-09 20:45 ` [PATCH v2 00/24] mtd: rawnand: Improve compile-test coverage Arnd Bergmann
2018-07-10 18:51 ` Paul Burton
2018-07-18 7:13 ` Miquel Raynal
2018-07-18 7:15 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180711131626.732967be@bbrezillon \
--to=boris.brezillon@bootlin.com \
--cc=arnd@arndb.de \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=marek.vasut@gmail.com \
--cc=miquel.raynal@bootlin.com \
--cc=ralf@linux-mips.org \
--cc=richard@nod.at \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.